Fix coord_comparison when coords are the same object #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djkirkham - could you possibly rebase this please and I'll take a look at getting it in. |
djkirkham
force-pushed
the
coord_comparison_id_check
branch
from
585de29 to
1f17472
Compare
|
As far as I was aware, cubes sharing coordinates was a big no-no. Given that we don't guard against it (clearly your tests show that), we either need to fix this, or fix the ability to create such a cube in the first place. It would not surprise me if this PR came up in the future if we decide to fix the latter, but for now, we need to fix the former... Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2771