-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid pypi namespace clash #2544
Conversation
@@ -194,7 +194,7 @@ def extract_version(): | |||
|
|||
|
|||
setup( | |||
name='Iris', | |||
name='iris-scitools', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this value only used by setuptools? If not I could see it causing unusual side-effects...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is my understanding that this is only used in setuptools/distutils
I would be greatly appreciative of supporting information for this assertion, i would like to minimise unwanted consequences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marqh the best I can come up with after quite a lot of looking is the first parargraph in this section, which is still far from definitive...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this 'name' appears in the folder structure of the installation via setuptools, e.g.:
>>> import iris; iris
<module 'iris' from '/home/h04/itmh/.local/lib/python2.7/site-packages/iris_scitools-1.12.0.dev0-py2.7.egg/iris/__init__.pyc'>
and in the PKG-INFO
Metadata-Version: 1.0
Name: iris-scitools
Version: 1.12.0.dev0
Summary: Data interoperability library
Home-page: http://scitools.org.uk/iris/
Author: UK Met Office
Author-email: https://groups.google.com/forum/#!forum/scitools-iris
License: LGPLv3
Description: Data interoperability library for meteorological and
oceanographic data formats, providing
data analysis and visualisation capabilities
Platform: any
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I prefer iris-scitools. If I was searching for this, I would feel more like I had found what I was looking for this way round than the other way around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My vote is for scitools-iris
, because that's how we always refer to Iris if we need to make it clear it's the SciTools package called Iris, such as we need to here. We've even used this name for Iris elsewhere in this PR...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's no practical reason to prefer one or the other, I prefer scitools-iris
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there appears to be something of a L:R split here
I think that the practical aspect of iris
appearing at the start of the string should carry the day, e.g.
If the packages were sorted alphabetically, and someone looked for iris they'd find iris-scitools nearby.
Although scitools-iris
might feel more natural to some developers, I think for the 'i want to find a package' use case which pypi addresses, iris-scitools
appears more practical to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd go for scitools-iris
as per PEP0423 (note: PEP status=deferred, but it does give some compelling evidence)
Closed by #2890. |
an update to the setup to change the 'name' of the package to
iris-scitools
to enable registry in pypiwe were exploring this years ago and have just been reminded of the request #606
uploading v1.12 won't work, as it clashes with the already registered
Iris
, but we can be ready for the next release