Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pin Proj4 #3154

Closed
pp-mo opened this issue Aug 31, 2018 · 3 comments
Closed

Don't pin Proj4 #3154

pp-mo opened this issue Aug 31, 2018 · 3 comments

Comments

@pp-mo
Copy link
Member

pp-mo commented Aug 31, 2018

Remove the pin "proj4<5", introduced in #3150

Background:
#3150 fixed problems emerging with cartopy and Proj4 v 5.1
Apparently triggered by new builds on conda_forge (though also anaconda?).
A new build of cartopy 0.16, though no new version.

Needs fixing properly, but probably better done in cartopy ?
Possibly, cartopy may not work properly with Proj4 >= 5.
Which said, the newest build of cartopy 0.16 may be effectively invalid

  • as here , lists as "py27h81b52dc_1 conda-forge",
@pp-mo pp-mo added this to the v2.2.0 milestone Aug 31, 2018
@DPeterK DPeterK modified the milestones: v2.2.0, v2.3.0 Oct 3, 2018
@pp-mo
Copy link
Member Author

pp-mo commented Aug 27, 2019

UPDATE:
despite relaxing the pin, we still have problem with this, since proj4 v6 came out + causes a variety of problems.

So for the future : we still need to remove the pin
( but now it means fixing proj4 v6 compatibility )

@pp-mo pp-mo removed this from the v2.3.0 milestone Aug 27, 2019
@trexfeathers
Copy link
Contributor

trexfeathers commented Jul 24, 2020

This is now a higher priority issue for fixing

Why

The proj4<6 pin now prevents Conda installing Iris with Cartopy>=0.18 - compare the installed packages for the latest Travis build against this experimental unpinned build.

Cartopy<0.18 also requires Matplotlib<3.3 - see #3759. So pins begetting more pins, each of which brings extra risk of future tech debt inflation (like what has already happened here).

It is also no longer possible for a pin of this sort to work - Iris' dependencies* are now referencing the proj package - this having replaced the proj4 package - and proj cannot be pinned back to the desired point since it 'took over' where proj4 stopped.

How


* The current dependency tree has proj being brought in via the gdal recipe (cartopy recently changed to include gdal in its recipe's host requirements, so no longer has any recipe references to proj).

@trexfeathers
Copy link
Contributor

Closed by #3762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants