Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix num2date / date2num multidimensional arrays. Remove iterator support. Fix masked arrays #68

Merged
merged 3 commits into from
Sep 15, 2016

Conversation

djkirkham
Copy link
Contributor

Fixes a bug where these functions wouldn't work with multidimensional arrays following a recent change.

I've also removed support for passing iterators to these functions to keep the code clean. Iterators weren't supported before the previous change.

@coveralls
Copy link

coveralls commented Sep 15, 2016

Coverage Status

Coverage decreased (-0.01%) to 90.526% when pulling 3f3301d on djkirkham:num2date-rounding into 3c7ee1b on SciTools:master.

@djkirkham
Copy link
Contributor Author

Previously the num2date functions would return None in an maked array where the input was masked. The date2num function would ignore the mask. I have maintained this functionality

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 90.226% when pulling e6f6ab1 on djkirkham:num2date-rounding into 3c7ee1b on SciTools:master.

@djkirkham djkirkham changed the title Fix num2date / date2num multidimensional arrays. Remove iterator support Fix num2date / date2num multidimensional arrays. Remove iterator support. Fix masked arrays Sep 15, 2016
@coveralls
Copy link

coveralls commented Sep 15, 2016

Coverage Status

Coverage decreased (-0.01%) to 90.526% when pulling 3bc6d71 on djkirkham:num2date-rounding into 3c7ee1b on SciTools:master.

@marqh marqh merged commit 273109d into SciTools:master Sep 15, 2016
@djkirkham djkirkham deleted the num2date-rounding branch September 16, 2016 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants