-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update readme badges #273
update readme badges #273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're not gonna like this 😅
I'm quite strongly against using HTML in markdown files unless it's absolutely necessary. It's not consistent with the .md
format, and is harder to read.
I appreciate that this is the only way to get centralised text/badges, but I just don't think it's worth it. That's why I introduced markdown badges in #179 a year ago (which you were happy to merge).
It would also obvs be way easier for me to review this if the format was consistent.
Sounds like we both have strong opinions. I'll happily bow to a third opinion from another dev (which would make it a quorum either way). |
@trexfeathers I honestly don't greatly mind. Tis fine 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Badges look good to me, and feel free to try alternatives to the commas.
Codacy has also picked up some boo boos I made in my original reformatting. Could you address those?
🚀 Pull Request
Description
This PR updates and refreshes the
README.md
badges.Notably, badges to the GHA CI and RTD have been added, and the badge to the now defunct
cirris-ci
has been removed.The changes render as follows:
See here.