Linting

[trexfeathers]

🚀 Pull Request

Description

Closes #171.

Adds the 'standard' SciTools linters, and tidies some other small things.

[codecov]

Codecov Report

Merging #179 (7555e8f) into master (50e44d0) will not change coverage.
The diff coverage is 88.28%.

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files           7        7           
  Lines         829      829           
  Branches      105      105           
=======================================
  Hits          751      751           
  Misses         64       64           
  Partials       14       14           

Impacted Files	Coverage Δ
cf_units/_udunits2.pyx	95.00% <ø> (ø)
cf_units/util.py	81.81% <50.00%> (ø)
cf_units/_udunits2_parser/__init__.py	89.21% <87.50%> (ø)
cf_units/__init__.py	89.49% <89.02%> (ø)
cf_units/_udunits2_parser/graph.py	97.95% <100.00%> (ø)
cf_units/config.py	71.42% <100.00%> (ø)
cf_units/tex.py	96.15% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50e44d0...7555e8f. Read the comment docs.

[trexfeathers]

The coverage reduction I think is to be expected, given the lines that Black tends to add. Depending on the reviewer's preference, I am happy for us to:

a. Temporarily alter the coverage settings to be tolerant of this shift.
b. Merge with a CI failure.

Let me know 🙂

[bjlittle]

@trexfeathers Since there might be a bit of fluctuation given that we're moving stuff around and linting et al, I'd suggest making the codecov regression suitably large to accommodate changes, then once the dust settles, bump it back to 0.5%

[bjlittle]

@trexfeathers Looking good... just a couple of comments to service 👍

[trexfeathers]

Thanks @bjlittle !