Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type preservation #164

Merged
merged 4 commits into from
Jun 15, 2021
Merged

Conversation

znicholls
Copy link
Contributor

Closes #163

Copy link
Collaborator

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution @znicholls! And sorry for letting this go stale.

Please could you rebase, and service my suggestion for making the code more generic?

@znicholls znicholls force-pushed the 163-type-preservation branch from d67e9a7 to c1d0279 Compare June 15, 2021 10:51
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #164 (4edec8a) into master (02ae952) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   90.48%   90.61%   +0.13%     
==========================================
  Files           7        7              
  Lines         830      831       +1     
  Branches      105      105              
==========================================
+ Hits          751      753       +2     
  Misses         64       64              
+ Partials       15       14       -1     
Impacted Files Coverage Δ
cf_units/__init__.py 89.53% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ae952...4edec8a. Read the comment docs.

@znicholls
Copy link
Contributor Author

sorry for letting this go stale

No worries, lots happening

Please could you rebase, and service my suggestion for making the code more generic?

Done

@znicholls znicholls requested a review from trexfeathers June 15, 2021 11:01
@trexfeathers trexfeathers merged commit 7f6cde4 into SciTools:master Jun 15, 2021
@rcomer rcomer added this to the v3.0.0 milestone Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Casting to integer on conversion
5 participants