Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deligate equality to other if conversion to Unit fails. #150

Merged
merged 2 commits into from
Jul 24, 2019
Merged

Deligate equality to other if conversion to Unit fails. #150

merged 2 commits into from
Jul 24, 2019

Conversation

mrshannon
Copy link
Contributor

This fixes issue #149 by returning NotImplemented if other is not or cannot be converted to a Unit. By doing this Unit allows other to make the decision or in the case that neither can determine equality Python will fallback on identity.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 88.489% when pulling 63bbb1a on mrshannon:fix_issue_149 into 812009c on SciTools:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 88.489% when pulling 63bbb1a on mrshannon:fix_issue_149 into 812009c on SciTools:master.

@coveralls
Copy link

coveralls commented Mar 29, 2019

Coverage Status

Coverage increased (+2.8%) to 91.457% when pulling 95e99cc on mrshannon:fix_issue_149 into 812009c on SciTools:master.

@bjlittle bjlittle added this to the v2.1.2 milestone Jul 23, 2019
@bjlittle bjlittle self-assigned this Jul 23, 2019
@bjlittle
Copy link
Member

@mrshannon Sorry for the very tardy response... I clearly missed this, but let's bank it now (finally) and include it in a patch release

@bjlittle
Copy link
Member

@mrshannon LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants