Added the UDUNITS2 grammar and a graph representation of a unit #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtensive test suite.
pelson
commented
Jan 29, 2019
pelson
commented
Jan 29, 2019
pelson
commented
Jan 29, 2019
bjlittle
reviewed
Jan 29, 2019
bjlittle
reviewed
Jan 29, 2019
bjlittle
reviewed
Jan 29, 2019
| | product power // e.g. m2s (s*m^2) | ||
| | product MULTIPLY power // e.g. m2*s | ||
| | product DIVIDE power // e.g. m2/2 | ||
| | product WS+ power // e.g. "m2 s" |
There was a problem hiding this comment.
@pelson So the UDUNITS-2 grammar doesn't explicitly define this last case, and yet supports it? Is that right?
There was a problem hiding this comment.
Yes. Also space is defined in the MULTIPLY token in the C grammar, but that isn't actually accurate (whitespace is significant in other parts of the codebase).
bjlittle
reviewed
Jan 29, 2019
bjlittle
reviewed
Jan 29, 2019
bjlittle
reviewed
Jan 29, 2019
bjlittle
reviewed
Jan 29, 2019
bjlittle
reviewed
Jan 29, 2019
bjlittle
reviewed
Jan 29, 2019
bjlittle
reviewed
Jan 29, 2019
bjlittle
reviewed
Jan 29, 2019
bjlittle
reviewed
Jan 29, 2019
bjlittle
reviewed
Jan 29, 2019
stickler-ci
reviewed
Jan 29, 2019
bjlittle
reviewed
Jan 29, 2019
bjlittle
reviewed
Jan 29, 2019
bjlittle
reviewed
Jan 29, 2019
|
@pelson Awesome! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final step before adding a super trivial interface to turn a graph into a TeX representation (or any other representation we want now [sympy?]).