Remove the _Unit factory, and make it a class method. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Jan 17, 2019
pelson
commented
Jan 17, 2019
| @@ -1509,15 +1513,16 @@ def _op_common(self, other, op_func): | |||
| raise ValueError("Cannot %s a 'no-unit'." % op_label) | |||
|
|
|||
| if self.is_unknown() or other.is_unknown(): | |||
| result = _Unit(_CATEGORY_UNKNOWN, None) | |||
| result = Unit(_UNKNOWN_UNIT_STRING) | |||
There was a problem hiding this comment.
This is the alternative to #125. Really, let's avoid encoding the meaning of UNKNOWN unit in multiple places, and let the constructor (__init__) deal with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a somewhat bizarre
_Unitfactory function that is there to allow construction of a unit if we already have the Udunits handle, and don't need to go through full__init__.Unfortunately, this factory is hiding the fact that it is an optimisation, and should IMO be much more explicit about the fact. The problem of how well concealed the
_UnitvsUnitis highlighted by the existing implementation, which is being addressed in #125. In this PR, I fix this by not short-circuiting__init__when we don't need to.This then is an alternative to #125.