Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed pep8 from test dependencies #963

Merged
merged 3 commits into from
Nov 29, 2017
Merged

Conversation

corinnebosley
Copy link
Member

Closes #905

@pp-mo
Copy link
Member

pp-mo commented Nov 29, 2017

Still to-do here : now stickler is working, remove the whole testclass cartopy.tests.test_coding_standards.TestCodeFormat, as that is all now done in CI not tests.

If I have it right, the idea is that now this is in CI not the test suite. You can perform a manual check with the "flake8" command, which has its own controls in "setup.cfg".

@stickler-ci
Copy link

I couldn't find a .stickler.yml file in this repository. I can make one for you, or you can create one by following the documentation.

@corinnebosley
Copy link
Member Author

forgot to rebase...

@corinnebosley
Copy link
Member Author

@pp-mo Could do with your eyes on this one now too please.

@pp-mo
Copy link
Member

pp-mo commented Nov 29, 2017

All looking fine,
except your test_coding_standards is still importing pep8, which needs to go.

If we had stickler working, it would warn about that !
(still waiting on #970)

@corinnebosley
Copy link
Member Author

Oops, quite right @pp-mo, I've pulled it out now.

@pp-mo pp-mo merged commit 869503c into SciTools:master Nov 29, 2017
@pp-mo
Copy link
Member

pp-mo commented Nov 29, 2017

Also checked locally in merge with #970.
All good !

@corinnebosley corinnebosley deleted the remove_pep8 branch November 29, 2017 15:09
@QuLogic QuLogic added this to the 0.16 milestone Jan 4, 2018
strezen pushed a commit to strezen/cartopy that referenced this pull request Feb 9, 2018
removed pep8 from test dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants