-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added feature that generates the elementary weight of a rooted tree as a latexstring #155
Conversation
Almost forgot: |
Good point 👍 Could you please rename the function as suggested - and deprecate the old one? help?> @deprecate
@deprecate old new [export_old=true]
Deprecate method old and specify the replacement call new, defining a new method old with the
specified signature in the process.
To prevent old from being exported, set export_old to false.
│ Julia 1.5
│
│ As of Julia 1.5, functions defined by @deprecate do not print warning when julia is
│ run without the --depwarn=yes flag set, as the default value of --depwarn option is
│ no. The warnings are printed from tests run by Pkg.test().
Examples
≡≡≡≡≡≡≡≡
julia> @deprecate old(x) new(x)
old (generic function with 1 method) |
I changed the name and deprecated the old function. Also changed the version number to 3.0.0 since it is a breaking change, right? Also the picture should be added to the documentation and I don't know how... |
You can insert some code similar to RootedTrees.jl/docs/src/tutorials/basics.md Lines 83 to 85 in e9698cf
|
The code is something like  |
Co-authored-by: Hendrik Ranocha <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! It's weird that docs CI fails. I will check it in another clean PR (#157)
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Added the feature as described in #96.

Also added test and they all passed.
Added documentation, but the picture of the output is still missing, since I don't remember how to add pictures there ...
This picture should be displayed: