From c434e7807e5ae94c3ac3ce38a4181a24fba92e47 Mon Sep 17 00:00:00 2001 From: Christopher Rackauckas Date: Sat, 12 Nov 2022 12:04:12 +0100 Subject: [PATCH] Mark fixed tests as not broken Found in https://github.com/SciML/SciMLBase.jl/actions/runs/3448009869/jobs/5754619602 --- test/interface/ad.jl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/interface/ad.jl b/test/interface/ad.jl index 6544c3a..94e62b2 100644 --- a/test/interface/ad.jl +++ b/test/interface/ad.jl @@ -28,7 +28,7 @@ h(p, t) = p[4] p = [1.0, 1.5, 1.0, 0.5] findiff2 = FiniteDiff.finite_difference_gradient(p -> test(vcat(p, p[end])), p) fordiff2 = ForwardDiff.gradient(p -> test(vcat(p, p[end])), p) - @test_broken maximum(abs.(findiff2 .- fordiff2)) < 2 + @test maximum(abs.(findiff2 .- fordiff2)) < 2 # with discontinuity and without delay length estimation p = [1.5, 1.0, 0.5, 1.0] @@ -62,7 +62,7 @@ end p = [1.0, 1.5, 1.0, 0.5] findiff2 = FiniteDiff.finite_difference_jacobian(p -> test(vcat(p, p[end])), p) fordiff2 = ForwardDiff.jacobian(p -> test(vcat(p, p[end])), p) - @test_broken maximum(abs.(findiff2 .- fordiff2)) < 3 + @test maximum(abs.(findiff2 .- fordiff2)) < 3 # with discontinuity and without delay length estimation p = [1.5, 1.0, 0.5, 1.0] @@ -96,7 +96,7 @@ end p = [1.0, 1.5, 1.0, 0.5] findiff2 = FiniteDiff.finite_difference_hessian(p -> test(vcat(p, p[end])), p) fordiff2 = ForwardDiff.hessian(p -> test(vcat(p, p[end])), p) - @test_broken maximum(abs.(findiff2 .- fordiff2)) < 25 + @test maximum(abs.(findiff2 .- fordiff2)) < 25 # with discontinuity and without delay length estimation p = [1.5, 1.0, 0.5, 1.0]