Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation error #55

Closed
nitrosx opened this issue Jan 24, 2023 · 3 comments · Fixed by #58
Closed

Validation error #55

nitrosx opened this issue Jan 24, 2023 · 3 comments · Fixed by #58
Assignees
Labels
bug Something isn't working

Comments

@nitrosx
Copy link
Member

nitrosx commented Jan 24, 2023

When uploading a new dataset, the client upload the files and than create a new dataset object and validate this new dataset.
If there is any issue with the newly created dataset, user will receive a validation error, after the files have been uploaded.

As a user, I would expect to receive the validation errors before any upload happens.

@nitrosx nitrosx added the bug Something isn't working label Jan 24, 2023
@jl-wynen
Copy link
Collaborator

Good point! This needs to be fixed.

Unfortunately, this only helps with Scitacean's validation. The server might still reject the dataset. Is there a way to ask if a dataset is valid without creating it in the database?

@nitrosx
Copy link
Member Author

nitrosx commented Jan 24, 2023

In the new backend, we added an endpoint that validate the data model, but does not create the entry.
Unfortunately, in the old backend there is not such functionality.

@jl-wynen
Copy link
Collaborator

Ok. For now, let's validate locally before file upload. And add remote validation when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants