Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and updated tests for delete #688

Open
nitrosx opened this issue Aug 25, 2023 · 0 comments
Open

Review and updated tests for delete #688

nitrosx opened this issue Aug 25, 2023 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@nitrosx
Copy link
Member

nitrosx commented Aug 25, 2023

Summary

@minottic discovered and reported that the delete endpoints are returning 200 if the document is not deleted.
This is hard to test and, to be consistent, we should return a different code. He suggests 404.
This issues has been derived from PR #662

Current Behaviour

if you delete a document, the endpoint return 200 no matter if the document has been deleted or not.

Expected Behaviour

When the delete endpoint is not able to delete the requested document, it should return a code different than 200.
@minottic suggests a 404

@nitrosx nitrosx added bug Something isn't working enhancement New feature or request labels Aug 25, 2023
@minottic minottic self-assigned this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants