fix: handle obsolete where filter fields mapping to current schema #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpedersen2
reviewed
Nov 26, 2024
| @@ -64,7 +64,6 @@ OIDC_USERQUERY_OPERATOR=<"or"|"and"> | |||
| OIDC_USERQUERY_FILTER="username:username, email:email" | |||
|
|
|||
| ELASTICSEARCH_ENABLED=<"yes"|"no"> | |||
| APP_PORT=3003 | |||
There was a problem hiding this comment.
This ENV variable is not used anywhere and I felt the change was too small to open a PR.. As it's an unused variable in an example file
bpedersen2
approved these changes
Nov 26, 2024
Junjiequan
force-pushed
the
SWAP-4303-scicat-be-debug-and-fix-dataset-proposal-update-n
branch
2 times, most recently
from
2197d80 to
d3b6eab
Compare
Junjiequan
force-pushed
the
SWAP-4303-scicat-be-debug-and-fix-dataset-proposal-update-n
branch
from
d3b6eab to
5f75362
Compare
nitrosx
approved these changes
Nov 27, 2024
Junjiequan
deleted the
SWAP-4303-scicat-be-debug-and-fix-dataset-proposal-update-n
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new function, convertObsoleteWhereFilterToCurrentSchema, to handle mapping obsolete filter fields (e.g., proposalId → proposalIds, sampleId → sampleIds) to their current schema equivalents.
Motivation
Fixes
Changes:
Tests included
Documentation
official documentation info