Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(casl-ability): correct instrument endpoint access for unauthentic… #1393

Merged

Conversation

Junjiequan
Copy link
Member

…ated users

Description

This PR aims to fix instrument endpoint access for unauthenticated users.

Motivation

Fixes:

  • Items added

Changes:

changed from cannot(Action.InstrumentRead, Instrument) to can(Action.InstrumentRead, Instrument);

  • changes made

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

@Junjiequan Junjiequan force-pushed the SWAP-4190-scicat-be-create-a-permission-check-endpoint-for branch from c00b77e to cbacc6e Compare August 23, 2024 08:44
@Junjiequan Junjiequan force-pushed the SWAP-4190-scicat-be-create-a-permission-check-endpoint-for branch from cbacc6e to 6f9828d Compare August 26, 2024 08:33
Copy link
Contributor

@sofyalaski sofyalaski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is correct since information about the instrument is probably available on the facilities website too..?

@Junjiequan
Copy link
Member Author

I assume this is correct since information about the instrument is probably available on the facilities website too..?

Yes. If we check the instruments schema, it contains no access or ownership related fields.

@Junjiequan Junjiequan merged commit 213d0df into master Aug 26, 2024
8 checks passed
@Junjiequan Junjiequan deleted the SWAP-4190-scicat-be-create-a-permission-check-endpoint-for branch August 26, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants