Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update datasets fullquery to use pid instead of _id #1182

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

Junjiequan
Copy link
Member

@Junjiequan Junjiequan commented Apr 19, 2024

Description

The _id and pid for datasets can be different when created manually. This change will use pid as the source of truth for the dataset's fullquery.

    "_id" : "20.500.12269/34e117ea-9502-404f-8db1-0c1cd5f6d9d9",
    "updatedBy" : "admin",
    "createdAt" : ISODate("2023-09-05T09:51:49.954+0000"),
    "updatedAt" : ISODate("2023-09-05T09:51:49.954+0000"),
    "ownerGroup" : "262651",
    "accessGroups" : [
        "swap"
    ],
    "pid" : "20.500.12269/b140f8fd-660d-4429-af72-77b499153b16",

Motivation

Background on use case, changes needed

Fixes:

  • Items added

Changes:

  • changes made

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?

@Junjiequan Junjiequan requested a review from nitrosx April 19, 2024 07:51
@nitrosx
Copy link
Member

nitrosx commented Apr 19, 2024

If we are talking about datasets, _id, id and pid should never be different.
IF we have experienced this behavior, it is a major bug and needs to be fixed

Copy link
Member

@nitrosx nitrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check if datasets document with pid different than _id have been created by mistake or they are systematic.
Approving this PR anyway, although the two fields should be exactly the same

@Junjiequan Junjiequan merged commit 617e4b4 into master Apr 19, 2024
7 checks passed
@Junjiequan Junjiequan deleted the full-query-find-method-modification branch April 19, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants