Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SESANS into GUI Design (Trac #346) #481

Closed
pkienzle opened this issue Mar 30, 2019 · 5 comments
Closed

SESANS into GUI Design (Trac #346) #481

pkienzle opened this issue Mar 30, 2019 · 5 comments
Assignees
Labels
Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour SESANS SESANS functionality

Comments

@pkienzle
Copy link
Contributor

pkienzle commented Mar 30, 2019

In order to include SESANS fully in all parts of the GUI with plotting and fitting need to agree on the design - first visually then code/module wise. example issue to look into:

  1. How to integrate w/ SANS fitting in GUI
  2. How to identify if data is SESANS (in correlation space) or SANS (reciprocal space) ... and how to make clear graphically
  3. If correlation space models are available how to choose what models to present to user seemlessly -- note that for full power scripting would always be the way to go but for GUI want to make transparent and easy for the user
  4. What modules will need to be refactored and what new modules created in order to support above?
  5. Should we start by making an independent SESANS perspective in order to explore the possibilities first without breaking trunk?

Once this is done tickets for the actual work will need to be generated

Migrated from http://trac.sasview.org/ticket/346

{
    "status": "assigned",
    "changetime": "2016-06-19T16:10:08",
    "_ts": "2016-06-19 16:10:08.920165+00:00",
    "description": "In order to include SESANS fully in all parts of the GUI with plotting and fitting need to agree on the design - first visually then code/module wise.  example issue to look into:\n1. How to integrate w/ SANS fitting in GUI\n2. How to identify if data is SESANS (in correlation space) or SANS (reciprocal space) ... and how to make clear graphically\n3. If correlation space models are available how to choose what models to present to user seemlessly -- note that for full power scripting would always be the way to go but for GUI want to make transparent and easy for the user\n4. What modules will need to be refactored and what new modules created in order to support above?\n5. Should we start by making an independent SESANS perspective in order to explore the possibilities first without breaking trunk?\n\nOnce this is done tickets for the actual work will need to be generated",
    "reporter": "pkienzle",
    "cc": "",
    "resolution": "",
    "workpackage": "SESANS Integration",
    "time": "2015-02-18T15:19:10",
    "component": "SasView",
    "summary": "SESANS into GUI Design",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView Next Release +1",
    "owner": "ajj",
    "type": "enhancement"
}
@pkienzle pkienzle added this to the SasView Next Release +1 milestone Mar 30, 2019
@pkienzle pkienzle added Enhancement Feature requests and/or general improvements Incomplete Migration Major Big change in the code or important change in behaviour SESANS SESANS functionality and removed Incomplete Migration labels Mar 30, 2019
@butlerpd
Copy link
Member

Trac update at 2016/03/06 19:49:08:

  • butler commented:

Clearly the start of this is labelled as core task for 4.0. Could be labelled critical since we don't have to complete, but will mark it blocker as it is the overarching ticket (need subtickets) for this code camp

  • butler changed milestone from "SasView Next Release +1" to "SasView 4.0.0"
  • butler changed priority from "minor" to "blocker"

@butlerpd
Copy link
Member

Trac update at 2016/03/06 23:27:37:

  • butler changed description from:

Include SESANS fully in all parts of the GUI with plotting and fitting

to:

In order to include SESANS fully in all parts of the GUI with plotting and fitting need to agree on the design - first visually then code/module wise. example issue to look into:

  1. How to integrate w/ SANS fitting in GUI
  2. How to identify if data is SESANS (in correlation space) or SANS (reciprocal space) ... and how to make clear graphically
  3. If correlation space models are available how to choose what models to present to user seemlessly -- note that for full power scripting would always be the way to go but for GUI want to make transparent and easy for the user
  4. What modules will need to be refactored and what new modules created in order to support above?
  5. Should we start by making an independent SESANS perspective in order to explore the possibilities first without breaking trunk?

Once this is done tickets for the actual work will need to be generated

  • butler changed owner from "" to "ajj"
  • butler changed status from "new" to "assigned"
  • butler changed summary from "SESANS into GUI" to "SESANS into GUI Design"

@sasview-bot
Copy link

Trac update at 2016/03/21 18:52:05: krzywon commented:

Work that has been done so far:

(1) A SESANS data reader is available so SESANS data can be loaded in to !SasView using the normal loader.Load() method.
(2) SESANS data have unique attributes in the SESANS1D data to distinguish it from SANS data. A check is already done in sasmodels.direct_model.!DataMixin, but would need to be integrated into the main fitting loop.
(3) To plot the data, plotting methods are built into sasmodels.data.py. The fit currently has two options and is based on the SESANS data - {z} vs. {P/P0} or {z} vs. {(Log (P/P0))/lambda^2^}.
(4) A general Hankel transform and one with a finite angle acceptance are written in models.sesans.py and are being tested. A Cosine2D transformation is in the works.
(5) A quick script (sasmodels.example.fit_sesans.py, which accepts a parameters.py file, calls sasmodels.example.sesansfit.py) is available that loads in a data set, model and model parameters and feeds that to the bumps gui.

Work that is needed:

(1) Add the SESANS data type check to the main loop and feed fitting through the transform in the main sasmodels fitting loop.
(2) Add a checkbox to the fit page to say if the data should be interpreted as SESANS or not to perform transforms on models for testing purposes. Default the checkbox to the appropriate value, but keep it variable.
(3) Add a section to the fit page to set the SESANS transform parameters (transform module and acceptance angle). Make defaults based on the SESANS data (already done in sesans.py) but keep all variable.
(4) Before any of this is done, make sure all available transforms are tested thoroughly.

@butlerpd
Copy link
Member

Trac update at 2016/06/19 16:10:08:

  • butler commented:

This ticket was also blocker as it was the subject of one of the team's work at code camp but GUI for SESANS was never intended to be in 4.0 release. As we are well out of code camp and release 4.0 alpha is out am now moving to next +1

Paul

  • butler changed milestone from "SasView 4.0.0" to "SasView Next Release +1"
  • butler changed priority from "blocker" to "major"

@butlerpd
Copy link
Member

This was done a while back. We agreed to close this at codecampX. If there are specific new items about the GUI (and there are) they should be the subject of their own new issues (and many are).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour SESANS SESANS functionality
Projects
None yet
Development

No branches or pull requests

4 participants