Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to streamline requiring new version of packages (Trac #322) #457

Closed
butlerpd opened this issue Mar 30, 2019 · 9 comments
Closed

Need to streamline requiring new version of packages (Trac #322) #457

butlerpd opened this issue Mar 30, 2019 · 9 comments
Labels
Defect Bug or undesirable behaviour Enhancement Feature requests and/or general improvements Minor Small job
Milestone

Comments

@butlerpd
Copy link
Member

butlerpd commented Mar 30, 2019

Currently requiring a new version of, for example bumps, requires changes be made in five separate places: build_tools/* (mac builder, RPM builder and windows builder), setup.py and check_packages.py

Migrated from http://trac.sasview.org/ticket/322

{
    "status": "new",
    "changetime": "2019-02-03T04:20:59",
    "_ts": "2019-02-03 04:20:59.908754+00:00",
    "description": "Currently requiring a new version of, for example bumps, requires changes be made in five separate places: build_tools/* (mac builder, RPM builder and windows builder), setup.py and check_packages.py",
    "reporter": "butler",
    "cc": "",
    "resolution": "",
    "workpackage": "SasView Framework Enhancements",
    "time": "2015-02-14T14:01:13",
    "component": "SasView",
    "summary": "Need to streamline requiring new version of packages",
    "priority": "minor",
    "keywords": "",
    "milestone": "SasView 4.3.0",
    "owner": "",
    "type": "defect"
}
@butlerpd butlerpd added this to the SasView 4.3.0 milestone Mar 30, 2019
@butlerpd butlerpd added Defect Bug or undesirable behaviour Incomplete Migration Minor Small job and removed Incomplete Migration labels Mar 30, 2019
@butlerpd
Copy link
Member Author

Trac update at 2015/03/10 15:18:54: butler commented:

want a configuration file that specifies all the version dependencies in one place to be used by the build systems.

@butlerpd
Copy link
Member Author

Trac update at 2015/03/10 16:56:12:

  • butler commented:

Not required for release and not likely to get done before release -- moving from 3.1 to release +1

  • butler changed milestone from "SasView 3.1" to "SasView Next Release +1"

@butlerpd
Copy link
Member Author

Trac update at 2015/08/14 20:11:01: butler changed milestone from "SasView Next Release +1" to "SasView 4.0.0"

@butlerpd
Copy link
Member Author

Trac update at 2016/03/20 22:45:39: butler changed milestone from "SasView 4.0.0" to "SasView Next Release +1"

@butlerpd
Copy link
Member Author

Trac update at 2019/02/03 04:20:59:

  • butler commented:

Is this fixed by the yml files?

  • butler changed milestone from "SasView Next Release +1" to "SasView 4.3.0"

@butlerpd
Copy link
Member Author

@krzywon @rozyczko @wpotrzebowski @pkienzle - is this now fixed? I.e is there a single master list of dependencies? I think Jeff's checkpackages project now has that at least using the yml files. is that all we have now storing the versions? If so I can close this ticket. Otherwise will move it to 5.1

@krzywon
Copy link
Contributor

krzywon commented Apr 27, 2020

In theory, the work I did on check packages could be a fix for this, but might require an update to the yaml files. In 5.x there are 10 different yaml files in the repo, each of which is used for something slightly different. I wasn't comfortable enough to add a new dependency I created for the check_packages because (1) I didn't know which of the yaml files I should edit and (2) I wasn't sure the proper versions for non-Windows systems.

A README in the /build_tools/ directory outlining what each file is used for might prove useful.

@butlerpd butlerpd modified the milestones: SasView 4.3.0, SasView 5.1.0 Apr 27, 2020
@butlerpd
Copy link
Member Author

Ok then will punt to 5.1 I guess to hopefully really kill this beast.

@lucas-wilkins lucas-wilkins added Enhancement Feature requests and/or general improvements and removed Migrated from Trac labels Oct 31, 2022
@lucas-wilkins
Copy link
Contributor

This is all done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Enhancement Feature requests and/or general improvements Minor Small job
Projects
None yet
Development

No branches or pull requests

3 participants