Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invariant failures #2334

Open
butlerpd opened this issue Oct 30, 2022 · 1 comment · Fixed by #2357
Open

Invariant failures #2334

butlerpd opened this issue Oct 30, 2022 · 1 comment · Fixed by #2357
Assignees
Labels
Defect Bug or undesirable behaviour Invariant Perspective Concerns invariant perspective

Comments

@butlerpd
Copy link
Member

Describe the bug
A couple of major issues were found during code camp:

  1. the q range is no longer settable. The range test boxes act as labels and the range sliders do not update the boxes either.
  2. Using the example apoferritin.txt data, the perspective computes ok with the default values for background(0) and scale (1) and contrast (8e-6). It also works if you choose to extrapolate both low and high Q. However, if one enters correct values (from the fitting of the data), namely 0.0023 background, 0.0003 scale and 4e04 SLD the calculator fails with:Calculation failed: not enough values to unpack (expected 3, got 0). Enabling the extrapolations leads the same error being thrown for each of the extrapolations (so 3 errors). E.g. the low Q extrapolation leads to Low-q calculation failed: not enough values to unpack (expected 3,got 0)

It is not clear why the correct values should fail unless it is due to the large error bars at high q which cannot be removed due to inability to constrain the q range used.

To Reproduce
Steps to reproduce the behavior:

  1. Load the apoferritin.txt example data
  2. send the data to the invariant perspective -- things should work
  3. try to adjust the range (either with the sliders or manually in the panel) -- you cannot
  4. Change the input parameters to reasonable values
  5. the computation now fails

Expected behavior
it should work

SasView version (please complete the following information):

  • Version: 5.0.5

Operating system (please complete the following information):

  • OS: [e.g. Windows 10]
@wpotrzebowski wpotrzebowski self-assigned this Oct 30, 2022
@lucas-wilkins lucas-wilkins added the Defect Bug or undesirable behaviour label Oct 31, 2022
@krzywon
Copy link
Contributor

krzywon commented Nov 8, 2022

#2357 only addressed part of the issue - reopening.

@krzywon krzywon reopened this Nov 8, 2022
@ajj ajj added the Invariant Perspective Concerns invariant perspective label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Invariant Perspective Concerns invariant perspective
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants