Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slicer does not properly update when model parameters change #2100

Open
jack-rooks opened this issue Jun 21, 2022 · 3 comments · Fixed by #1919
Open

Slicer does not properly update when model parameters change #2100

jack-rooks opened this issue Jun 21, 2022 · 3 comments · Fixed by #1919
Assignees
Labels
Being Tested When an issue is done but not ready to be closed. Defect Bug or undesirable behaviour Slicers Concerns slicer functionality

Comments

@jack-rooks
Copy link
Contributor

Describe the bug
The annulus slicer in the GUI does not properly update when the model parameters are changed. This bug report describes the Npts in Fit Options not updating, but this also applies to other parameters in the Model tab.

To Reproduce
Steps to reproduce the behavior:

  1. Open SasView and look at the fitting panel that is open by default
  2. Select a category and model (cylinder and cylinder was used for this)
  3. Enable "2D view" in the options section at the bottom left of the fitting panel
  4. (Optional) Enter desired parameters
  5. Click "Calculate" then "Show Plot" at the bottom right of the window
  6. Right click the 2D plot that was generated and either click "Sector [Q View]" (or "Edit Slicer Parameters" and select the "Sector" slicer type from the dropdown)
  7. (Optional) Adjust sector angle and width to desired region. Increasing nbins may make the problem more apparent
  8. Return to the fitting panel. Go to Fit Options > Data Points > Npts and change (for example, to twice the default)
  9. Note that the 1D sector average from step 6 does not update
  10. Right click the 2D pattern and select "Clear Slicer"
  11. Repeat steps 6-7. Note how the resulting 1D sector average is updated

Note: This behavior is most apparent when the slicer bins (in slicer parameters, edited in step 7) is greater than the initial Npts from the fitting window (step 4). This is because with more bins than there are points, there will be gaps in the sector average. When the Npts is increased, these gaps should be filled to some extent.

Expected behavior
The 1D sector average should update when the 2D pattern it is averaging changes without requiring closing and reopening the slicer.

Screenshots
Attached image shows the window during several steps

SasView version (please complete the following information):

  • Version: 5.0.4

Operating system (please complete the following information):

  • OS: Windows 10 (build 19044)
    SasView_BugReport_Npts

Additional context
Also tested for scale, background, sld, sld_solvent, radius, length, theta, and phi which all displayed this behavior

@jack-rooks jack-rooks added the Defect Bug or undesirable behaviour label Jun 21, 2022
@lucas-wilkins lucas-wilkins added the Slicers Concerns slicer functionality label Jul 20, 2022
@butlerpd
Copy link
Member

we should check this but I think it has been resolved?

@jack-rooks
Copy link
Contributor Author

jack-rooks commented Apr 19, 2023

I have tested on 5.0.6b1 and observe the same behavior as in the initial report

EDIT: I uninstalled SasView, used the installer labeled as version 5.0.6rc1, and launched to test. The version listed at the top of the window was 5.0.6b1

@jack-rooks jack-rooks self-assigned this Jan 19, 2024
@jack-rooks
Copy link
Contributor Author

Fixed by 2100_2726_2752_Slicer-bugfixes. Leaving this open for now as it has not been merged

@jack-rooks jack-rooks added the Being Tested When an issue is done but not ready to be closed. label Jan 21, 2024
@jack-rooks jack-rooks linked a pull request Jan 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Being Tested When an issue is done but not ready to be closed. Defect Bug or undesirable behaviour Slicers Concerns slicer functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants