Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze theory no longer works #1851

Closed
rozyczko opened this issue May 17, 2021 · 5 comments
Closed

Freeze theory no longer works #1851

rozyczko opened this issue May 17, 2021 · 5 comments
Labels
Critical High priority Defect Bug or undesirable behaviour For Feature Parity Issues to give 5x the same functionality as 4x
Milestone

Comments

@rozyczko
Copy link
Member

  1. create a theory
  2. try to freeze it
  3. TypeError: can't pickle QLineEdit objects

This comes from the recent addition of plot sliders. Each data/theory item contains now a QLineEdit object, which is not copyable.
copy.deepcopy in cloneTheory() will have to be replaced with a more complex method, allowing for copying of QObject derived types.

@rozyczko rozyczko added Critical High priority Defect Bug or undesirable behaviour labels May 17, 2021
@rozyczko rozyczko added this to the SasView 5.0.5 milestone May 17, 2021
@rozyczko
Copy link
Member Author

Alternatively, can we simplify the slider storage so it just keeps its max/min numerical values in the model item rather than the whole line edit object?

@rozyczko
Copy link
Member Author

Cloning a QObject is not really feasible https://stackoverflow.com/questions/2855495/qobject-cloning

This means we can either do it manually, copying fields one by one or, again, refrain from keeping a QObject inside Data1D/Data2D structures.

@butlerpd butlerpd added the For Feature Parity Issues to give 5x the same functionality as 4x label Oct 12, 2021
@butlerpd
Copy link
Member

Is this the same issue as #1418? I note that @ajj says he had to revert to 4.x for his demo because he needed the freeze theory and it was not working for him. We should probably #1418 if this supersedes?

@rozyczko
Copy link
Member Author

Nope. This is a new issue, recently fixed in PR #1891

@butlerpd
Copy link
Member

Thanks @rozyczko - This was not linked to the PR which was closed today so I am closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical High priority Defect Bug or undesirable behaviour For Feature Parity Issues to give 5x the same functionality as 4x
Projects
None yet
Development

No branches or pull requests

2 participants