Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rg*Qmax and Rg*Qmin are inverted in the Gunier linear fit #1782

Closed
butlerpd opened this issue Feb 9, 2021 · 1 comment
Closed

Rg*Qmax and Rg*Qmin are inverted in the Gunier linear fit #1782

butlerpd opened this issue Feb 9, 2021 · 1 comment
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Milestone
SasView 5.0.4

Comments

@butlerpd
Copy link
Member

butlerpd commented Feb 9, 2021

Rg*qmax is an important quantity for verifying the validity of the linearized Rg calculation. Roughly it should be less than 1 though for a sphere it can be much as high as 2.

The linear fit for the Rg reports Rgqmin in the box labelled Rgqmax and the Rgqmax value is reported in the Rgqmin box.

This should be very simple fix but is quite confusing at first.
@butlerpd butlerpd added Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour labels Feb 9, 2021
@butlerpd butlerpd added this to the SasView 5.0.4 milestone Feb 9, 2021
This was referenced Feb 10, 2021
Closed
Merged
@krzywon
Copy link
Contributor

krzywon commented Feb 12, 2021

This was fixed when the PR was merged. Closing.

@krzywon krzywon closed this as completed Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Projects
None yet
Milestone
SasView 5.0.4
Development

Successfully merging a pull request may close this issue.

Linear Fit Rg*Qmin & Rg*Qmax SasView/sasview
2 participants
@krzywon @butlerpd