Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invariant does not report the total invariant #1606

Closed
butlerpd opened this issue Jun 29, 2020 · 4 comments · Fixed by #1590
Closed

Invariant does not report the total invariant #1606

butlerpd opened this issue Jun 29, 2020 · 4 comments · Fixed by #1590
Assignees
Labels
Critical High priority Defect Bug or undesirable behaviour
Milestone

Comments

@butlerpd
Copy link
Member

In 5.x series the invariant appears to only always report the invariant under the actual data on the front panel (under Invariant Total [Q] regardless of whether or not extrapolation is chosen. The only way to get the total would be to click the status button and sum the contributions.

Given the value being reported is called "Total" (and would be expected to be the total) I am labeling this as critical.

@smk78
Copy link
Contributor

smk78 commented Jul 2, 2020

4.x master is correctly returning the Invariant Total (ie, the sum of the low-Q integral + data integral + high-Q integral)

@wpotrzebowski wpotrzebowski self-assigned this Jul 3, 2020
@wpotrzebowski
Copy link
Contributor

wpotrzebowski commented Jul 3, 2020

Yes, it seems that 5.x is missing:

self._qstar += qs_low + qs_hi
self._qstar_err = math.sqrt(self._qstar_err * self._qstar_err \
+ dqs_low * dqs_low + dqs_hi * dqs_hi)

@wpotrzebowski wpotrzebowski linked a pull request Jul 6, 2020 that will close this issue
@butlerpd
Copy link
Member Author

I believe this ticket should be closed. I t was addressed in the July hackathon and fixed in 5.0.3 if memory serves. Part of the problem of conflating issues and PR in the sprint project board I think?

@krzywon
Copy link
Contributor

krzywon commented Dec 10, 2020

I just checked in release v5.0.3 and this is fixed.

@krzywon krzywon closed this as completed Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical High priority Defect Bug or undesirable behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants