Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem loading canSAS data into Invariant #1605

Closed
butlerpd opened this issue Jun 29, 2020 · 1 comment · Fixed by #1709
Closed

Problem loading canSAS data into Invariant #1605

butlerpd opened this issue Jun 29, 2020 · 1 comment · Fixed by #1709
Labels
Defect Bug or undesirable behaviour Invariant Perspective Concerns invariant perspective Major Big change in the code or important change in behaviour
Milestone

Comments

@butlerpd
Copy link
Member

butlerpd commented Jun 29, 2020

The latex_smeared.xml data set in the test folder includes 2 separate curves: a slit smeared low Q USANS data set and a high Q pinhole smeared SANS data set. These are loaded as two separate files into the data manager. Checking only one of the data sets allows only that data to be sent to be plotted or to fitting and once fitted and plotted with the fit only that data set is shown. however, when sent to the invariant both the checked AND unchecked data sets are plotted in the invariant plot though it appears the Invariant is only calculated from the chosen data set? At least the default qmin and qmax come from that data set and the extrapolations appear to be made from that data set.
NOTE: This is true in 5.0.2 and in the local build of the 5.x invariant branch. The dataloader work may or may not have changed this behaviour

@butlerpd butlerpd added Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour labels Jun 29, 2020
@butlerpd butlerpd added this to the SasView 5.0.4 milestone Jun 29, 2020
@krzywon
Copy link
Contributor

krzywon commented Aug 7, 2020

When Invariant wants to generate a new plot, it finds all data by filename, so both latex_smeared data sets are grabbed. I'm pretty sure this will be mostly resolved with #1652, because data are now labelled differently, but this won't be 100% foolproof. Ideally, the perspective would find data by data.id, which is a unique value, not by name or filename, which can have duplicate values.

@wpotrzebowski wpotrzebowski added the Invariant Perspective Concerns invariant perspective label Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Invariant Perspective Concerns invariant perspective Major Big change in the code or important change in behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants