Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crosstalk between Corfunc and Invariant perspectives #1542

Closed
butlerpd opened this issue May 17, 2020 · 5 comments · Fixed by #1709
Closed

Crosstalk between Corfunc and Invariant perspectives #1542

butlerpd opened this issue May 17, 2020 · 5 comments · Fixed by #1709
Assignees
Labels
Corfunc Perspective Concerns Correlation Function Perspective Critical High priority Defect Bug or undesirable behaviour Invariant Perspective Concerns invariant perspective
Milestone

Comments

@butlerpd
Copy link
Member

butlerpd commented May 17, 2020

As of 5.0.2, if one sends data to corfunc and plots it, then sends the same data to the invariant all behaves as expected. However, if in fact the data is sent to Corfunc and the correlation function plotted (hitting extrapolate and then transform) so that the second plot (the Real space data) before then sending the same data set to the invariant, there are two things wrong:

  1. the axis labels have now changed from I(Q) vs Q to gamma vs x(A)
  2. The plot not only contains the I(Q) data but also 3 lines whose labels suggest they are the 1D Correlation the 3D Correlation and the Interface Distribution Function which now, as described in issue Invariant and the infinite multiplication of plots #1541 get replicated in every plot every time one updates and recomputed the invariant.

NOTE: This can be fixed by sending the data to some other pesrpective and then sending back to the Invariant.

Seen on both Windows and Mac

@butlerpd butlerpd added Defect Bug or undesirable behaviour SasView GUI Enhancements Critical High priority labels May 17, 2020
@butlerpd butlerpd added this to the SasView 5.0.3 milestone May 17, 2020
@smk78
Copy link
Contributor

smk78 commented May 29, 2020

Quoting @butlerpd above:

NOTE: This can be fixed by sending the data to some other pesrpective and then sending back to the Invariant.

Actually, not quite. If you need to use the Append to button you will find every dataset created in your session gets appended to the graph!

@butlerpd
Copy link
Member Author

? I think that is another bug @smk78 ... or feature request some might say, which I forgot to enter but was meaning to. Or did I misunderstand your comment? basically, if you try to plot any dataset that has been used for fitting of various kinds you have to tick the box then create (or append) to plot will plot that data set and ALL the children of that dataset. That is because when you tick that box the default is to ALSO tick the hidden boxes of all the child plots.
Another problem I have is that the number of child plots becomes very unwieldy and not sure we need them all there but that is probably a much bigger and deeper design/logic issue

I will try to create this issue soon. is this the issue? or is it really the cross talk specifically between invariant and corfunc?

@smk78
Copy link
Contributor

smk78 commented May 29, 2020

No it's a general issue. If you use, say, corfunc, then invariant, and then fitting, and then find you want to append to the last graph window, everything SasView seems to know about gets appended, I(q) data, models, correlation functions, IDF's,...

@butlerpd
Copy link
Member Author

Good -- that is the other known issue but independent of this one. I will make it now. This issue is only a problem with invariant and corfunc and related to fitting in each. It does not cross talk with fitting in invariant or fitting from my tests.

@butlerpd butlerpd modified the milestones: SasView 5.0.3, SasView 5.0.4 Aug 18, 2020
@smk78 smk78 added the Corfunc Perspective Concerns Correlation Function Perspective label Sep 15, 2020
@krzywon krzywon self-assigned this Nov 27, 2020
@wpotrzebowski wpotrzebowski added the Invariant Perspective Concerns invariant perspective label Jan 12, 2021
@wpotrzebowski
Copy link
Contributor

ready for testing on OSX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Corfunc Perspective Concerns Correlation Function Perspective Critical High priority Defect Bug or undesirable behaviour Invariant Perspective Concerns invariant perspective
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants