Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort out the Invariant Perspective & Documentation (#1434 & #1461) #1472

Closed
wpotrzebowski opened this issue Mar 12, 2020 · 3 comments · Fixed by #1590
Closed

Sort out the Invariant Perspective & Documentation (#1434 & #1461) #1472

wpotrzebowski opened this issue Mar 12, 2020 · 3 comments · Fixed by #1590
Assignees
@RichardHeenan @smk78 @butlerpd @yunliu01
Labels
Invariant Perspective Concerns invariant perspective Major Big change in the code or important change in behaviour
Milestone
SasView 5.0.3

Comments

@wpotrzebowski
Copy link
Contributor

Sort out the Invariant Perspective & Documentation (#1434 & #1461)
@wpotrzebowski wpotrzebowski added the Invariant Perspective Concerns invariant perspective label Mar 12, 2020
@smk78 smk78 mentioned this issue Apr 16, 2020
Closed
@smk78
Copy link
Contributor

smk78 commented Apr 16, 2020

Ahead of the 5.0.2 release, invariant_help.rst from the ticket-1434 branch (the most current invariant docs) has been cherry-picked and copied into ESS_GUI master.

I have then added in the pre-prepared 5x invariant panel screenshots which also necessitated a small change the 'Using Invariant Analysis' text due to different behaviour to 4x

@smk78 smk78 added this to the SasView 5.0.3 milestone Apr 22, 2020
@butlerpd butlerpd added the Major Big change in the code or important change in behaviour label May 26, 2020
@butlerpd
Copy link
Member

Now that the first pass fix is understood and tested for 4.x need to make those changes to the 5.x branch.

@wpotrzebowski wpotrzebowski linked a pull request Jun 18, 2020 that will close this issue
Ess gui 1574 invariant #1590
Merged
@butlerpd
Copy link
Member

This was created for the hackathon. Only #1461 was relevant to 5.x the remaining #1434 needs to be finished but is an issue in 4.x so am going to close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RichardHeenan RichardHeenan

@smk78 smk78

@butlerpd butlerpd

@yunliu01 yunliu01

Labels
Invariant Perspective Concerns invariant perspective Major Big change in the code or important change in behaviour
Projects
None yet
Milestone
SasView 5.0.3
Development

Successfully merging a pull request may close this issue.

Ess gui 1574 invariant SasView/sasview
5 participants
@wpotrzebowski @RichardHeenan @smk78 @butlerpd @yunliu01