Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Http Angular 2 compliant #39

Open
1 of 3 tasks
SamVerschueren opened this issue Apr 3, 2016 · 1 comment
Open
1 of 3 tasks

Make Http Angular 2 compliant #39

SamVerschueren opened this issue Apr 3, 2016 · 1 comment

Comments

@SamVerschueren
Copy link
Owner

SamVerschueren commented Apr 3, 2016

All the HTTP methods should transform their responses to observables to make it Angular 2 compliant.

  • Return observables f98bdce
  • Transform response to ng2 response
  • Add possibility to inject extra options (see RequestOptions)
@SamVerschueren
Copy link
Owner Author

This isn't the only thing that should be done to make it angular 2 compliant. The response that is returned by the service should be a ng2 response object as well with methods like toJson(), etc.

Some references:

https://github.com/angular/angular/blob/2.0.0-beta.15/modules/angular2/src/http/http.ts
https://github.com/angular/angular/blob/2.0.0-beta.15/modules/angular2/src/http/static_response.ts

And what's up with that ConnectionBackend stuff?

https://github.com/angular/angular/blob/2.0.0-beta.15/modules/angular2/src/http/base_request_options.ts

@SamVerschueren SamVerschueren changed the title HTTP should return observables instead of promises Make Http Angular 2 compliant Apr 16, 2016
@SamVerschueren SamVerschueren added this to the v0.1.0 milestone Apr 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant