Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display workout with imperial units #99

Closed
SamR1 opened this issue Oct 16, 2021 · 3 comments · Fixed by #111
Closed

Display workout with imperial units #99

SamR1 opened this issue Oct 16, 2021 · 3 comments · Fixed by #111

Comments

@SamR1
Copy link
Owner

SamR1 commented Oct 16, 2021

see #96 (comment) & #18 (comment)

@SamR1 SamR1 mentioned this issue Oct 16, 2021
30 tasks
@SamR1
Copy link
Owner Author

SamR1 commented Oct 16, 2021

#18 (comment)

@SamR1 I've submitted one PR already for handling slow movement that I think should not impact the new UI, and I'm now working on the unit conversions. I'll try to make the unit conversion code usable across the new UI by handling most of it in the model itself, but can you make the labels in the new UI, such as "km" and "m" pull from a central variable?

No problem, I will update labels in the new UI.

This feature needs a new user preference (like for the start of week or language), in order to allow user to choose between metric or imperial units.
On API side, it would be great that depending on this preference, values returned by api are either with metrics units or with imperial units.

@Fmstrat
Copy link
Contributor

Fmstrat commented Oct 18, 2021

PR complete: #102

@Fmstrat
Copy link
Contributor

Fmstrat commented Oct 18, 2021

I should note, I patched this out of a branch with the Docker/React elements so it would be easier to review, but all my testing was done post your React change for Docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants