Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sport: open water swimming #400

Closed
xmgz opened this issue Jul 18, 2023 · 4 comments
Closed

Add new sport: open water swimming #400

xmgz opened this issue Jul 18, 2023 · 4 comments

Comments

@xmgz
Copy link

xmgz commented Jul 18, 2023

as suggested, I open this issue to discuss about swimming activities

as FitTrackee requires a valid .gpx file from outdoor activities I request Open Water Swimming to be added as activity.

Adding a generic Swimming would make possible to manually add an activity recorded in the swimming pool (without gps data) so it would be prefered (in my opinion). Same as other indoor activities without .gpx values.

this is a .gpx file from garmin device if you need to check if there's any diference to be taken in consideration
activity_11528282494(1).zip so others could upload here a file from other devices to check if there is any particular format or values to consider.

I would suggest that elevation values should be overwritten to 0 (zero) in case GPS glitches or errors could introduce any value (please comment if this is incorrect from my side)

Please comment so devs can add swimming in future releases. Thank you.

@SamR1
Copy link
Owner

SamR1 commented Jul 18, 2023

Hi,

Thanks for opening this issue and the .gpx file.
With the current version of FitTrackee, it displays the following data from the file:
Screenshot 2023-07-18 at 08-42-03 FitTrackee - Séance

It shouldn't display ascent and descent, since the file does not contain elevation data (no <ele> element) .

      <trkpt lat="<LATITUTE>" lon="<LONGITUDE>">
        <time>2023-07-10T10:37:45.000Z</time>
        <extensions>
          <ns3:TrackPointExtension>
            <ns3:atemp>20.0</ns3:atemp>
            <ns3:cad>0</ns3:cad>
          </ns3:TrackPointExtension>
        </extensions>
      </trkpt>

I'll fix that and add open water swimming (indoor activities need more change and different display).

@SamR1 SamR1 changed the title Add new sport: swimming Add new sport: open water swimming Jul 19, 2023
@SamR1 SamR1 added this to the v0.7 - OAuth 2.0 milestone Jul 19, 2023
@xmgz
Copy link
Author

xmgz commented Jul 21, 2023

Speed values usually are noted as minutes per one hundred meters (min/100m), at least in the two or three apps/sites I have used.

As conversion is trivial, I don't know if speed charts and values are the same for every sport or if they can be formatted by the kind of activity.

I'm totally fine if speed keeps the current format and I don't know if min/100m is actually any kind of standard.

Thank you.

Note: this could be applicable also to running where we usually talk about pace in terms of minutes per kilometer (mile).

So initally could be best to keep it as it is and then.. open a diferent issue

@SamR1
Copy link
Owner

SamR1 commented Jul 22, 2023

Hi,

Yes, I agree. I've already opened an issue to display pace (#302) :).

@SamR1
Copy link
Owner

SamR1 commented Jul 22, 2023

released in v0.7.20

@SamR1 SamR1 closed this as completed Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants