Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_email_url() can't validate a legitimate EMAIL_URI such as "smtp://localhost:25" #127

Closed
vincentxavier opened this issue Dec 27, 2021 · 2 comments
Labels
api bug v0.5.x Issues planned in versions 0.5.x

Comments

@vincentxavier
Copy link

"smtp://localhost:25" is a valid, as of urllib3.util.parse_url and parsed_url.auth is None, so .split(':'), wont work.

@rwc0888
Copy link

rwc0888 commented Dec 30, 2021

"smtp://localhost:25" is a valid, as of urllib3.util.parse_url and parsed_url.auth is None, so .split(':'), wont work.

I was stuck on this issue for a long time until I discovered this in the documentation. It seems you need to use something like smtp://username:[email protected]:25.

@SamR1
Copy link
Owner

SamR1 commented Dec 31, 2021

Hi,

Sorry for the delay.

Yes, the valid format for FitTrackee is smtp://username:password@host:port.
But I will add support for email URL without authentication.

@SamR1 SamR1 added api bug v0.5.x Issues planned in versions 0.5.x labels Dec 31, 2021
@SamR1 SamR1 added this to the v0.5 - Better UI milestone Jan 1, 2022
@SamR1 SamR1 closed this as completed in 33fde03 Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api bug v0.5.x Issues planned in versions 0.5.x
Projects
None yet
Development

No branches or pull requests

3 participants