Action is very slow as compared to other

[noorcs]

Hi,
I don't if it makes sense to ask this,

I tested SamKirkland/FTP-Deploy-Action and found that its very slow. I just tested it with upload a single file to server. It takes more than 2 minutes to complete the action.

Then I tested https://github.com/sebastianpopp/ftp-action , and that worked fast comparatively.

Attached is the screenshot of SamKirkland/FTP-Deploy-Action with the title "Publish Website over SFTP"

and sebastianpopp/ftp-action with the title "Deploy via ftp"

I am still curious and feel that SamKirkland action may the one to go with,
but I can't wait 2 minutes each time.
Before using these actions I used to commit and push my changes to github and then use the another FTP software like FileZilla to upload my files to the server,
Now I want it to be a single step, when I push changes to github, they should be automatically uploaded to server too.

But am I using it the right way? because most of the times there are less than 10 files mostly 2 to 3 files to upload to server.

Sorry if I haven't explained the issue clearly.

[SamKirkland]

Hey, thanks for bringing this to my attention. I'll try to help debug the issue.
The action shouldn't be taking that long. It's likely due to using SFTP instead of FTP. Can you reply with the detail action logs? To get the action logs click on the slow action --> Then click "..." in the top right corner --> then click "View raw logs".

I followed a very similar workflow for years (using FileZilla to keep my local and source control in sync). That's the exact use case for this github action :)
I would like to point out that you shouldn't be testing your code on the production sever and you should try to have a local testing environment so you can quickly test/debug your code. Then commit your code once you've got a working solution. Setting up a local database and PHP (in my case) server is a bit time consuming but will definitely be worth the effort in the long run, especially if you configure vscode with php Xdebug.

On another note the other deployment action you reference is actually just a fork of this one from a few months ago, the only real differences are mine is up to date with SFTP support. If you deploy via FTP instead I expect the deployment times to be similar.

[noorcs]

Dear I have local development server. I do complete development and testing on local server. once its ready for the production then I push changes to live production server.

Here is the raw log:

2019-11-23T21:31:05.7980790Z ##[section]Starting: Request a runner to run this job
2019-11-23T21:31:06.0595858Z Requesting a hosted runner in current repository's account/organization with labels: 'ubuntu-latest', require runner match: True
2019-11-23T21:31:06.1195947Z Labels matched hosted runners has been found, waiting for one of them get assigned for this job.
2019-11-23T21:31:06.1495909Z ##[section]Finishing: Request a runner to run this job
2019-11-23T21:31:12.4905043Z Current runner version: '2.160.2'
2019-11-23T21:31:12.4905979Z Prepare workflow directory
2019-11-23T21:31:12.5108755Z Prepare all required actions
2019-11-23T21:31:12.5137186Z Download action repository 'actions/checkout@master'
2019-11-23T21:31:13.8973282Z Download action repository 'SamKirkland/[email protected]'
2019-11-23T21:31:14.9328830Z Build container for action use: '/home/runner/work/_actions/SamKirkland/FTP-Deploy-Action/2.0.0/Dockerfile'.
2019-11-23T21:31:14.9386904Z ##[command]/usr/bin/docker build -t 2e4e3a:f6aff17bb61b4485b8a44cebf7d0801e "/home/runner/work/_actions/SamKirkland/FTP-Deploy-Action/2.0.0"
2019-11-23T21:31:15.4768874Z Sending build context to Docker daemon 192.5kB
2019-11-23T21:31:15.4770231Z
2019-11-23T21:31:15.5892999Z Step 1/14 : FROM alpine:3.10
2019-11-23T21:31:15.5895010Z ---> 965ea09ff2eb
2019-11-23T21:31:15.5895179Z Step 2/14 : LABEL version="1.0.0"
2019-11-23T21:31:16.3728951Z ---> Running in 4351d42f8575
2019-11-23T21:31:17.3813697Z Removing intermediate container 4351d42f8575
2019-11-23T21:31:17.3816107Z ---> ee9ea464592b
2019-11-23T21:31:17.3819077Z Step 3/14 : LABEL repository="https://github.com/SamKirkland/FTP-Deploy-Action"
2019-11-23T21:31:17.3820570Z ---> Running in 2d8bbec4fd80
2019-11-23T21:31:18.0089427Z Removing intermediate container 2d8bbec4fd80
2019-11-23T21:31:18.0090948Z ---> ed4215634847
2019-11-23T21:31:18.0093122Z Step 4/14 : LABEL homepage="https://github.com/SamKirkland/FTP-Deploy-Action"
2019-11-23T21:31:18.0331398Z ---> Running in 83e8df831c55
2019-11-23T21:31:19.3818529Z Removing intermediate container 83e8df831c55
2019-11-23T21:31:19.3820377Z ---> 889a3afd1c50
2019-11-23T21:31:19.3822196Z Step 5/14 : LABEL maintainer="Sam Kirkland [email protected]"
2019-11-23T21:31:19.3850272Z ---> Running in 70c3db106132
2019-11-23T21:31:20.0088728Z Removing intermediate container 70c3db106132
2019-11-23T21:31:20.0170789Z ---> 3bde3ef23ebd
2019-11-23T21:31:20.0171121Z Step 6/14 : LABEL "com.github.actions.name"="FTP Deploy Action"
2019-11-23T21:31:20.0245425Z ---> Running in 9dc6f98cd54c
2019-11-23T21:31:21.0120478Z Removing intermediate container 9dc6f98cd54c
2019-11-23T21:31:21.0120883Z ---> 5d58fe2c03c7
2019-11-23T21:31:21.0211383Z Step 7/14 : LABEL "com.github.actions.description"="Deploy your website via FTP"
2019-11-23T21:31:21.0368550Z ---> Running in 122cc3382571
2019-11-23T21:31:22.0170821Z Removing intermediate container 122cc3382571
2019-11-23T21:31:22.0171218Z ---> 100d2b104bd9
2019-11-23T21:31:22.0171431Z Step 8/14 : LABEL "com.github.actions.icon"="upload-cloud"
2019-11-23T21:31:22.0276171Z ---> Running in f20d1d199e5f
2019-11-23T21:31:23.0171361Z Removing intermediate container f20d1d199e5f
2019-11-23T21:31:23.0171574Z ---> fe9836a28315
2019-11-23T21:31:23.0172416Z Step 9/14 : LABEL "com.github.actions.color"="orange"
2019-11-23T21:31:23.0343740Z ---> Running in 638bc8a74a17
2019-11-23T21:31:24.0105094Z Removing intermediate container 638bc8a74a17
2019-11-23T21:31:24.0105255Z ---> 8ae049dfd0bf
2019-11-23T21:31:24.0105541Z Step 10/14 : RUN apk update
2019-11-23T21:31:24.0268970Z ---> Running in ecb5569742f6
2019-11-23T21:31:25.3239907Z fetch http://dl-cdn.alpinelinux.org/alpine/v3.10/main/x86_64/APKINDEX.tar.gz
2019-11-23T21:31:25.4814701Z fetch http://dl-cdn.alpinelinux.org/alpine/v3.10/community/x86_64/APKINDEX.tar.gz
2019-11-23T21:31:25.5765788Z v3.10.3-59-g1cf2a95d5e [http://dl-cdn.alpinelinux.org/alpine/v3.10/main]
2019-11-23T21:31:25.5765962Z v3.10.3-60-g4e358d491c [http://dl-cdn.alpinelinux.org/alpine/v3.10/community]
2019-11-23T21:31:25.5766087Z OK: 10339 distinct packages available
2019-11-23T21:31:26.0105510Z Removing intermediate container ecb5569742f6
2019-11-23T21:31:26.0139847Z ---> d549a57834b9
2019-11-23T21:31:26.0140117Z Step 11/14 : RUN apk add openssh sshpass lftp
2019-11-23T21:31:26.0382215Z ---> Running in 6561101d21a5
2019-11-23T21:31:26.4163925Z (1/15) Installing ncurses-terminfo-base (6.1_p20190518-r0)
2019-11-23T21:31:26.4316678Z (2/15) Installing ncurses-terminfo (6.1_p20190518-r0)
2019-11-23T21:31:26.6441658Z (3/15) Installing ncurses-libs (6.1_p20190518-r0)
2019-11-23T21:31:26.6565095Z (4/15) Installing readline (8.0.0-r0)
2019-11-23T21:31:26.6654643Z (5/15) Installing libgcc (8.3.0-r0)
2019-11-23T21:31:26.6721786Z (6/15) Installing libstdc++ (8.3.0-r0)
2019-11-23T21:31:26.6888139Z (7/15) Installing lftp (4.8.4-r2)
2019-11-23T21:31:26.7331259Z (8/15) Installing openssh-keygen (8.1_p1-r0)
2019-11-23T21:31:26.7445680Z (9/15) Installing libedit (20190324.3.1-r0)
2019-11-23T21:31:26.7528515Z (10/15) Installing openssh-client (8.1_p1-r0)
2019-11-23T21:31:26.7943623Z (11/15) Installing openssh-sftp-server (8.1_p1-r0)
2019-11-23T21:31:26.8015483Z (12/15) Installing openssh-server-common (8.1_p1-r0)
2019-11-23T21:31:26.8088946Z (13/15) Installing openssh-server (8.1_p1-r0)
2019-11-23T21:31:26.8224939Z (14/15) Installing openssh (8.1_p1-r0)
2019-11-23T21:31:26.8313793Z (15/15) Installing sshpass (1.06-r0)
2019-11-23T21:31:26.8388095Z Executing busybox-1.30.1-r2.trigger
2019-11-23T21:31:26.8564645Z OK: 22 MiB in 29 packages
2019-11-23T21:31:28.2558264Z Removing intermediate container 6561101d21a5
2019-11-23T21:31:28.2558421Z ---> d3ab10c3f94d
2019-11-23T21:31:28.2558512Z Step 12/14 : COPY entrypoint.sh /entrypoint.sh
2019-11-23T21:31:29.0115733Z ---> 8eb09211bf84
2019-11-23T21:31:29.0115918Z Step 13/14 : RUN chmod 777 entrypoint.sh
2019-11-23T21:31:29.0293468Z ---> Running in e3a92356d0b8
2019-11-23T21:31:30.0130830Z Removing intermediate container e3a92356d0b8
2019-11-23T21:31:30.0130987Z ---> 1c7945e42d3f
2019-11-23T21:31:30.0131081Z Step 14/14 : ENTRYPOINT ["/entrypoint.sh"]
2019-11-23T21:31:30.0371213Z ---> Running in bce47b420d79
2019-11-23T21:31:31.8852916Z Removing intermediate container bce47b420d79
2019-11-23T21:31:31.8853046Z ---> 6455d3017373
2019-11-23T21:31:31.8853139Z Successfully built 6455d3017373
2019-11-23T21:31:31.8853235Z Successfully tagged 2e4e3a:f6aff17bb61b4485b8a44cebf7d0801e
2019-11-23T21:31:31.9081259Z ##[group]Run actions/checkout@master
2019-11-23T21:31:31.9081548Z with:
2019-11-23T21:31:31.9081808Z clean: true
2019-11-23T21:31:31.9082067Z ##[endgroup]
2019-11-23T21:31:32.1865344Z Added matchers: 'checkout-git'. Problem matchers scan action output for known warning or error strings and report these inline.
2019-11-23T21:31:32.2035699Z Syncing repository: noorcs/myTestApp
2019-11-23T21:31:32.2186283Z ##[command]git version
2019-11-23T21:31:32.2411126Z git version 2.23.0
2019-11-23T21:31:32.2485504Z ##[command]git lfs version
2019-11-23T21:31:32.3691338Z git-lfs/2.9.0 (GitHub; linux amd64; go 1.13.1)
2019-11-23T21:31:32.3820230Z ##[command]git init "/home/runner/work/myTestApp/myTestApp"
2019-11-23T21:31:32.3897805Z Initialized empty Git repository in /home/runner/work/myTestApp/myTestApp/.git/
2019-11-23T21:31:32.3920742Z ##[command]git remote add origin https://github.com/noorcs/myTestApp
2019-11-23T21:31:32.3993294Z ##[command]git config gc.auto 0
2019-11-23T21:31:32.4032830Z ##[command]git config --get-all http.https://github.com/noorcs/myTestApp.extraheader
2019-11-23T21:31:32.4057206Z ##[command]git config --get-all http.proxy
2019-11-23T21:31:32.4132293Z ##[command]git -c http.extraheader="AUTHORIZATION: basic *" fetch --tags --prune --progress --no-recurse-submodules origin +refs/heads/:refs/remotes/origin/
2019-11-23T21:31:32.6356277Z remote: Enumerating objects: 37, done.
2019-11-23T21:31:32.6371195Z remote: Counting objects: 2% (1/37)
2019-11-23T21:31:32.6373350Z remote: Counting objects: 5% (2/37)
2019-11-23T21:31:32.6375161Z remote: Counting objects: 8% (3/37)
2019-11-23T21:31:32.6375631Z remote: Counting objects: 10% (4/37)
2019-11-23T21:31:32.6376153Z remote: Counting objects: 13% (5/37)
2019-11-23T21:31:32.6384689Z remote: Counting objects: 16% (6/37)
2019-11-23T21:31:32.6385020Z remote: Counting objects: 18% (7/37)
2019-11-23T21:31:32.6389210Z remote: Counting objects: 21% (8/37)
2019-11-23T21:31:32.6389574Z remote: Counting objects: 24% (9/37)
2019-11-23T21:31:32.6390177Z remote: Counting objects: 27% (10/37)
2019-11-23T21:31:32.6390582Z remote: Counting objects: 29% (11/37)
2019-11-23T21:31:32.6394682Z remote: Counting objects: 32% (12/37)
2019-11-23T21:31:32.6395147Z remote: Counting objects: 35% (13/37)
2019-11-23T21:31:32.6402337Z remote: Counting objects: 37% (14/37)
2019-11-23T21:31:32.6402750Z remote: Counting objects: 40% (15/37)
2019-11-23T21:31:32.6403025Z remote: Counting objects: 43% (16/37)
2019-11-23T21:31:32.6403319Z remote: Counting objects: 45% (17/37)
2019-11-23T21:31:32.6403707Z remote: Counting objects: 48% (18/37)
2019-11-23T21:31:32.6403948Z remote: Counting objects: 51% (19/37)
2019-11-23T21:31:32.6404358Z remote: Counting objects: 54% (20/37)
2019-11-23T21:31:32.6410520Z remote: Counting objects: 56% (21/37)
2019-11-23T21:31:32.6411251Z remote: Counting objects: 59% (22/37)
2019-11-23T21:31:32.6411678Z remote: Counting objects: 62% (23/37)
2019-11-23T21:31:32.6411897Z remote: Counting objects: 64% (24/37)
2019-11-23T21:31:32.6412099Z remote: Counting objects: 67% (25/37)
2019-11-23T21:31:32.6412298Z remote: Counting objects: 70% (26/37)
2019-11-23T21:31:32.6412501Z remote: Counting objects: 72% (27/37)
2019-11-23T21:31:32.6412779Z remote: Counting objects: 75% (28/37)
2019-11-23T21:31:32.6413043Z remote: Counting objects: 78% (29/37)
2019-11-23T21:31:32.6413252Z remote: Counting objects: 81% (30/37)
2019-11-23T21:31:32.6413453Z remote: Counting objects: 83% (31/37)
2019-11-23T21:31:32.6413687Z remote: Counting objects: 86% (32/37)
2019-11-23T21:31:32.6414459Z remote: Counting objects: 89% (33/37)
2019-11-23T21:31:32.6414687Z remote: Counting objects: 91% (34/37)
2019-11-23T21:31:32.6415477Z remote: Counting objects: 94% (35/37)
2019-11-23T21:31:32.6415961Z remote: Counting objects: 97% (36/37)
2019-11-23T21:31:32.6416772Z remote: Counting objects: 100% (37/37)
2019-11-23T21:31:32.6416996Z remote: Counting objects: 100% (37/37), done.
2019-11-23T21:31:32.6420599Z remote: Compressing objects: 5% (1/20)
2019-11-23T21:31:32.6421158Z remote: Compressing objects: 10% (2/20)
2019-11-23T21:31:32.6422130Z remote: Compressing objects: 15% (3/20)
2019-11-23T21:31:32.6423100Z remote: Compressing objects: 20% (4/20)
2019-11-23T21:31:32.6423629Z remote: Compressing objects: 25% (5/20)
2019-11-23T21:31:32.6424183Z remote: Compressing objects: 30% (6/20)
2019-11-23T21:31:32.6424881Z remote: Compressing objects: 35% (7/20)
2019-11-23T21:31:32.6425478Z remote: Compressing objects: 40% (8/20)
2019-11-23T21:31:32.6426209Z remote: Compressing objects: 45% (9/20)
2019-11-23T21:31:32.6426881Z remote: Compressing objects: 50% (10/20)
2019-11-23T21:31:32.6427427Z remote: Compressing objects: 55% (11/20)
2019-11-23T21:31:32.6428748Z remote: Compressing objects: 60% (12/20)
2019-11-23T21:31:32.6429489Z remote: Compressing objects: 65% (13/20)
2019-11-23T21:31:32.6430210Z remote: Compressing objects: 70% (14/20)
2019-11-23T21:31:32.6430934Z remote: Compressing objects: 75% (15/20)
2019-11-23T21:31:32.6431942Z remote: Compressing objects: 80% (16/20)
2019-11-23T21:31:32.6432881Z remote: Compressing objects: 85% (17/20)
2019-11-23T21:31:32.6433509Z remote: Compressing objects: 90% (18/20)
2019-11-23T21:31:32.6434120Z remote: Compressing objects: 95% (19/20)
2019-11-23T21:31:32.6434699Z remote: Compressing objects: 100% (20/20)
2019-11-23T21:31:32.6436932Z remote: Compressing objects: 100% (20/20), done.
2019-11-23T21:31:32.6438213Z remote: Total 37 (delta 10), reused 27 (delta 7), pack-reused 0
2019-11-23T21:31:32.6602938Z From https://github.com/noorcs/myTestApp
2019-11-23T21:31:32.6603988Z * [new branch] master -> origin/master
2019-11-23T21:31:32.6756089Z ##[command]git checkout --progress --force 4612665f8e722c845a75e18e1cb9ff6c546ab83c
2019-11-23T21:31:32.6798236Z Note: switching to '4612665f8e722c845a75e18e1cb9ff6c546ab83c'.
2019-11-23T21:31:32.6798375Z
2019-11-23T21:31:32.6799210Z You are in 'detached HEAD' state. You can look around, make experimental
2019-11-23T21:31:32.6799363Z changes and commit them, and you can discard any commits you make in this
2019-11-23T21:31:32.6800038Z state without impacting any branches by switching back to a branch.
2019-11-23T21:31:32.6800126Z
2019-11-23T21:31:32.6800245Z If you want to create a new branch to retain commits you create, you may
2019-11-23T21:31:32.6800647Z do so (now or later) by using -c with the switch command. Example:
2019-11-23T21:31:32.6800716Z
2019-11-23T21:31:32.6802155Z git switch -c
2019-11-23T21:31:32.6802389Z
2019-11-23T21:31:32.6802503Z Or undo this operation with:
2019-11-23T21:31:32.6802566Z
2019-11-23T21:31:32.6803161Z git switch -
2019-11-23T21:31:32.6803236Z
2019-11-23T21:31:32.6803498Z Turn off this advice by setting config variable advice.detachedHead to false
2019-11-23T21:31:32.6803556Z
2019-11-23T21:31:32.6803678Z HEAD is now at 4612665 confirm successfull deployment again
2019-11-23T21:31:32.6815616Z Removed matchers: 'checkout-git'
2019-11-23T21:31:32.7078399Z ##[group]Run SamKirkland/[email protected]
2019-11-23T21:31:32.7078571Z with:
2019-11-23T21:31:32.7078686Z method: ftp
2019-11-23T21:31:32.7078772Z port: 21
2019-11-23T21:31:32.7078874Z env:
2019-11-23T21:31:32.7078980Z FTP_SERVER: www.mySite.com
2019-11-23T21:31:32.7079088Z FTP_USERNAME: mySiteFTPUser
2019-11-23T21:31:32.7079612Z FTP_PASSWORD: ***
2019-11-23T21:31:32.7079711Z REMOTE_DIR: /home/mySite/public_html/myTestApp/
2019-11-23T21:31:32.7079821Z METHOD: ftp
2019-11-23T21:31:32.7079922Z PORT: 21
2019-11-23T21:31:32.7080022Z ##[endgroup]
2019-11-23T21:31:32.7114039Z ##[command]/usr/bin/docker run --name e4e3af6aff17bb61b4485b8a44cebf7d0801e_f6dfc6 --label 2e4e3a --workdir /github/workspace --rm -e FTP_SERVER -e FTP_USERNAME -e FTP_PASSWORD -e REMOTE_DIR -e METHOD -e PORT -e INPUT_FTP_SERVER -e INPUT_FTP_USERNAME -e INPUT_FTP_PASSWORD -e INPUT_METHOD -e INPUT_PORT -e INPUT_LOCAL_DIR -e INPUT_REMOTE_DIR -e INPUT_ARGS -e HOME -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e GITHUB_ACTIONS=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/myTestApp/myTestApp":"/github/workspace" 2e4e3a:f6aff17bb61b4485b8a44cebf7d0801e "" "" "" "ftp" "21" "" ""
2019-11-23T21:31:33.0246243Z Starting FTP Deploy
2019-11-23T21:31:33.0246685Z Using ftp to connect to port 21
2019-11-23T21:31:33.0247093Z Uploading files...
2019-11-23T21:33:16.4231887Z FTP Deploy Complete
2019-11-23T21:33:16.6872160Z Cleaning up orphan processes

[noorcs]

And one more thing, I am using FTP with it. the title that is used in those test cases "Publish Website Over SFTP" is just the default and while associating action, i didn't modify the title.

[noorcs]

Here is my .yml file for this Action

  on: push
  name: Publish Website over SFTP
  jobs:
    FTP-Deploy-Action:
      name: FTP-Deploy-Action
      runs-on: ubuntu-latest
      steps:
      - uses: actions/checkout@master
      
      - name: FTP-Deploy-Action
        uses: SamKirkland/[email protected]
        env:
          FTP_SERVER: www.mySite.com
          FTP_USERNAME: mySiteFTPUser
          FTP_PASSWORD: ${{ secrets.MYSITE_FTP_PASSWORD }}
          REMOTE_DIR: /home/reliet/public_html/myTestApp/
          METHOD: ftp
          PORT: 21

[SamKirkland]

Can you add the following as ARGS: --verbose --continue
This will let you see which files are being uploaded and how long each is taking.

[sebastienserre]

Because .git folder not excluded (there's a lot of things inside it) ?

[sebastienserre]

no, I think it takes time because you are removing file then re-uploading them even if they have no change.

If you have the possibility to check if file change (by date or size), you'll be able to skip them and get performances

[sebastienserre]

@noorcs did you check #16 ?

[SamKirkland]

V3 will now only publish different files.

Breaking change: v3 will only publish tracked (committed) files by default. If your file isn't in source control you will have to add it .git-ftp-include see example