Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGE: Contextual help in Donation Selector modal #4108

Merged
merged 8 commits into from
Mar 12, 2019

Conversation

bethbrains
Copy link
Contributor

@bethbrains bethbrains commented Mar 8, 2019

  • Added help text in Review Donations pop-up window to explain which Opportunity and Payment will be displayed.

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

<lightning:layout verticalAlign="stretch" multipleRows="true">

<!--Contextual help to explain which records will appear-->
<lightning:layoutItem size="12"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd put this on one line until the attributes list grows a bit longer

Copy link
Contributor

@ptewson-sfdo ptewson-sfdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'approve!

@melissabarber melissabarber self-requested a review March 11, 2019 22:02
@ptewson-sfdo ptewson-sfdo merged commit ae607f9 into master Mar 12, 2019
@ptewson-sfdo ptewson-sfdo deleted the feature/beth-donation-selector-helptext branch March 12, 2019 20:59
@sam-knox
Copy link
Contributor

@melissabarber - Do we need to say anything in the Changes section for this one?

@melissabarber
Copy link
Contributor

Nope! Thanks for checking, @sam-knox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants