Feature/pt bdi support checkbox fields #4105

ptewson-sfdo · 2019-03-07T23:14:45Z

Bring more responsible support for mapping to checkbox fields to BDI/BGE. Mapped field on
Data Import must be picklist with None/True/False or text field for full support, but current user processes that use checkbox-to-checkbox mappings will be unaffected by this change.

Critical Changes

Changes

Batch Gift Entry Enhancements

Batch Gift Entry now supports improved mapping to standard and custom checkbox fields. In order to allow your users more flexibility around checkbox fields in Batch Gift Entry and Data Importer, the corresponding field should be a picklist. This picklist translates what you see in the Opportunity or Payment checkbox field (checked or unchecked) to their boolean equivalents (True for checked and False for unchecked). Through Batch Gift Entry, your users will be able to uncheck a previously checked checkbox field or even leave a checkbox field completely unchanged by leaving that field blank for any given donation line item. Read more about this in the Add Custom Fields to Your Batch documentation.

Issues Closed

New Metadata

Deleted Metadata

ptewson-sfdo · 2019-03-09T00:16:47Z

src/classes/BDI_DataImportService.cls

+            // This allows for mapping checkboxes to a tri-state picklist - None, True, False - or a text with either 
+            // blank, "True", or "False"
+            String destinationSObjectname = destinationRecord.getSObjectType().getDescribe().getName(); 
+            if ((UTIL_Describe.getFieldDisplayType(destinationSObjectname, destinationField) == 


Field name must be LOWERCASE. Also namespace support.

…alesforceFoundation/Cumulus into feature/pt-bdi-support-checkbox-fields

klewis-sfdc

A few stylistic comments is all from me! Looks great.

klewis-sfdc · 2019-03-15T00:44:21Z

src/classes/BDI_DataImportService.cls

+            // This allows for mapping checkboxes to a tri-state picklist - None, True, False - or a text with either 
+            // blank, "True", or "False"
+            String destinationSObjectname = destinationRecord.getSObjectType().getDescribe().getName(); 
+            if (!(value instanceof Boolean) && 


I know were nesting a few ifs here, but I might consider adding one more and putting the destinationSObjectname var inside the first value instanceof Boolean if block, since we don't need to get the SObject name to inspect this unless the field is Boolean.

Another option could be to extract the comparison to a little utility method, for readability - something like if(booleanMappingIsValid(value, destinationSObjectname). This is good - I'm just trying to think through it if it could be a little more readable what with multiple calls to those UTIL classes here.

klewis-sfdc · 2019-03-15T00:45:19Z

src/classes/BDI_DataImportService.cls

@@ -878,6 +878,18 @@ global with sharing class BDI_DataImportService {
                return false;
            }

+            // If the destination field is a Boolean and the DI field intermediate requires interpretation to Boolean
+            // This allows for mapping checkboxes to a tri-state picklist - None, True, False - or a text with either 


Will this allow for mapping from picklists with any values? if so we might not want to specifify "None" here, since admins can configure whatever PL values they want.

None just means null or no value ... it's important for the behavior but I've been struggling with how to type that to make it clear that it's not an actual picklist option with text "none" but that there IS a valid option in the picklist that is neither true or false and evaluates to null

Maybe I should just say "null" ... 🤔

And if the PL values aren't parse-able to a boolean value with Boolean.valueOf() it will fail

I see! Ok, yeah, very cool.

src/classes/BDI_DataImportService.cls

klewis-sfdc

One more little idea, but all up to you of course - this is super cool and exciting to add into bdi!

klewis-sfdc · 2019-03-15T06:48:25Z

src/classes/BDI_DataImportService.cls

@@ -878,6 +878,18 @@ global with sharing class BDI_DataImportService {
                return false;
            }

+            // If the destination field is a Boolean and the DI field intermediate requires interpretation to Boolean
+            // This allows for mapping checkboxes to a tri-state picklist - None, True, False - or a text with either 


I see! Ok, yeah, very cool.

klewis-sfdc · 2019-03-15T06:56:34Z

src/classes/BDI_DataImportService.cls

+            // This allows for mapping checkboxes to a tri-state picklist - None, True, False - or a text with either 
+            // blank, "True", or "False"
+            String destinationSObjectname = destinationRecord.getSObjectType().getDescribe().getName(); 
+            if (!(value instanceof Boolean) && 


Another option could be to extract the comparison to a little utility method, for readability - something like if(booleanMappingIsValid(value, destinationSObjectname). This is good - I'm just trying to think through it if it could be a little more readable what with multiple calls to those UTIL classes here.

cpose · 2019-03-15T17:36:24Z

**lurch: attach W-031084

…alesforceFoundation/Cumulus into feature/pt-bdi-support-checkbox-fields

klewis-sfdc · 2019-03-15T22:02:40Z

src/classes/BDI_DataImportService.cls

+            // null, "True", or "False"
+            if (!(value instanceof Boolean) && 
+                fieldIsBooleanDisplayType(destinationRecord, destinationField)) {
+


👍 much easier to read!!

Patrick Tewson and others added 6 commits March 7, 2019 15:08

Handle checkbox fields in BDI mapped to picklist on DI

11a265e

Handle checkbox fields in BDI mapped to picklist on DI

e1b6505

Handle checkbox fields in BDI mapped to picklist on DI

5c8242e

Handle checkbox fields in BDI mapped to picklist on DI

fd44250

Merge 8e71839 into feature/pt-bdi-support-checkbox-fields

3ab2529

Merge c1d610b into feature/pt-bdi-support-checkbox-fields

ad64fd5

ptewson-sfdo commented Mar 9, 2019

View reviewed changes

mrbelvedere and others added 14 commits March 11, 2019 11:22

Merge add8ce8 into feature/pt-bdi-support-checkbox-fields

c0b38e6

Merge ccecc5d into feature/pt-bdi-support-checkbox-fields

a21b637

Merge f778b82 into feature/pt-bdi-support-checkbox-fields

6beb3a8

Merge cba009f into feature/pt-bdi-support-checkbox-fields

f6d0bc8

Merge 2d6e390 into feature/pt-bdi-support-checkbox-fields

6967dfa

Merge ae607f9 into feature/pt-bdi-support-checkbox-fields

e909dd9

Merge b04a463 into feature/pt-bdi-support-checkbox-fields

3bd5533

Merge 2aec57e into feature/pt-bdi-support-checkbox-fields

5e548ff

Merge c388fd9 into feature/pt-bdi-support-checkbox-fields

0b329b5

add unit tests and namespace support

07b5c9b

Merge branch 'feature/pt-bdi-support-checkbox-fields' of github.com:S…

59246e4

…alesforceFoundation/Cumulus into feature/pt-bdi-support-checkbox-fields

add unit tests and namespace support

12cefcb

add unit tests and namespace support

e236d95

add unit tests and namespace support

363e373

ptewson-sfdo requested review from bethbrains and klewis-sfdc March 14, 2019 19:52

add unit tests and namespace support

573e838

klewis-sfdc reviewed Mar 15, 2019

View reviewed changes

klewis-sfdc approved these changes Mar 15, 2019

View reviewed changes

ptewson-sfdo requested a review from melissabarber March 15, 2019 16:32

Patrick Tewson and others added 2 commits March 15, 2019 10:55

move tangle of IF logic into its own supporting method

1ae96b0

Merge 7f8dcb7 into feature/pt-bdi-support-checkbox-fields

7797dde

Patrick Tewson added 2 commits March 15, 2019 13:02

address namespace issue

7e2f979

Merge branch 'feature/pt-bdi-support-checkbox-fields' of github.com:S…

10a240a

…alesforceFoundation/Cumulus into feature/pt-bdi-support-checkbox-fields

klewis-sfdc reviewed Mar 15, 2019

View reviewed changes

Patrick Tewson and others added 3 commits March 15, 2019 15:16

resolve namespace issue

309be2b

Merge 6f22315 into feature/pt-bdi-support-checkbox-fields

1a8e3d8

Merge 4f0859a into feature/pt-bdi-support-checkbox-fields

cbe9ed2

ptewson-sfdo merged commit ed66093 into master Mar 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/pt bdi support checkbox fields #4105

Feature/pt bdi support checkbox fields #4105

ptewson-sfdo commented Mar 7, 2019 •

edited by melissabarber

Loading

ptewson-sfdo Mar 9, 2019

klewis-sfdc left a comment •

edited

Loading

klewis-sfdc Mar 15, 2019

klewis-sfdc Mar 15, 2019

klewis-sfdc Mar 15, 2019

ptewson-sfdo Mar 15, 2019

ptewson-sfdo Mar 15, 2019

ptewson-sfdo Mar 15, 2019

klewis-sfdc Mar 15, 2019

klewis-sfdc left a comment

klewis-sfdc Mar 15, 2019

klewis-sfdc Mar 15, 2019

cpose commented Mar 15, 2019 •

edited

Loading

klewis-sfdc Mar 15, 2019

Feature/pt bdi support checkbox fields #4105

Feature/pt bdi support checkbox fields #4105

Conversation

ptewson-sfdo commented Mar 7, 2019 • edited by melissabarber Loading

Critical Changes

Changes

Batch Gift Entry Enhancements

Issues Closed

New Metadata

Deleted Metadata

Choose a reason for hiding this comment

klewis-sfdc left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

klewis-sfdc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cpose commented Mar 15, 2019 • edited Loading

Choose a reason for hiding this comment

ptewson-sfdo commented Mar 7, 2019 •

edited by melissabarber

Loading

klewis-sfdc left a comment •

edited

Loading

cpose commented Mar 15, 2019 •

edited

Loading