Feature/robot bge automation #3933
Conversation
…lesforceFoundation/Cumulus into feature/robot__bge-automation
…me keywords and added click element with locator keyword
There was a problem hiding this comment.
One general comment I want to make is that about half of the keywords don't have any documentation. While some are self-explanatory and probably obvious to you right now, it will be difficult for others to use these keywords without having to read the code.
I would like to recommend that we require documentation for every keyword that is in a library or resource file. I realize that some keywords don't require much documentation (eg: click record button is fairly self-explanatory), but even in those cases a simple one sentence explanation is better than nothing at all.
It's important to remember that keywords in a library or resource file are intended to be reused. We need to make reuse as easy as possible, and robust documentation gets us closer to that goal.
| @@ -704,7 +687,7 @@ def select_value_from_list(self,list_name,value): | |||
| self.selenium.select_from_list_by_label(loc,value) | |||
|
|
|||
| def select_value_from_bge_dd(self,list_name,value): | |||
There was a problem hiding this comment.
What does "dd" stand for in this context? Dropdown? Date Dialog? Something else?
| Execute JavaScript window.document.evaluate('${xpath}', document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.scrollIntoView(true) | ||
| Select Duellist Values Payment Selected Fields Check/Reference Number | ||
| Click Duellist Button Payment Move selection to Available Fields | ||
| Click Element With Locator bge.duellist Opportunity Available Fields Donation Name |
There was a problem hiding this comment.
I like this block of changes. While it might have made the test slightly easier to read with some highly specialized keywords (select duellist values, click duellist button, etc), I think having one general purpose keyword instead of multiple special-purpose keywords will help make it easier to learn and use the NPSP keywords.
|
@melissabarber - Can you take a look at the release notes for this PR? |
|
@sam-knox @melissabarber no release notes for this one, it's updates to test automation |
|
@melissabarber oh. which is the edit you made. carry on :) |
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata