Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sabaki doesn't quit on macOS #157

Open
golddranks opened this issue Jan 6, 2017 · 7 comments
Open

Sabaki doesn't quit on macOS #157

golddranks opened this issue Jan 6, 2017 · 7 comments
Labels
blocked bug electron help wanted macos
Milestone
Backlog

Comments

@golddranks
Copy link

If I press ⌘Q or "Quit Sabaki" from the menu, I expect it to close down for good. Instead, it just closes the window, but remains open at background.
@yishn yishn changed the title Sabaki doesn't close on macOS Sabaki doesn't quit on macOS Jan 6, 2017
@yishn yishn added this to the v0.20.0 milestone Jan 6, 2017
@yishn yishn closed this as completed in f9bd1d7 Jan 7, 2017
@yishn yishn reopened this Jan 7, 2017
@yishn yishn added the electron label Jan 7, 2017
@yishn yishn closed this as completed in 1ae2fe5 Jan 7, 2017
@yishn yishn reopened this Jan 7, 2017
@yishn
Copy link
Member

yishn commented Jan 7, 2017

It seems that this bug is a consequence of the fix of #149. Which in turn is a bug of Electron.

@yishn yishn removed this from the v0.20.0 milestone Jan 10, 2017
@yishn yishn added this to the Backlog milestone Jan 26, 2017
This was referenced Mar 24, 2017
Closed
Merged
@yishn yishn modified the milestones: v0.30.0, Backlog Mar 27, 2017
@yishn yishn modified the milestones: Backlog, v0.30.* Apr 16, 2017
@Jendker
Copy link

Jendker commented Jul 6, 2018

The bug ist still not resolved

@yishn
Copy link
Member

yishn commented Jul 6, 2018 •
edited
Loading

Can‘t be fixed until electron/electron#9966 is fixed.

@atahrijouti
Copy link

There must be another way of handling the closing. I mean, VS Code, Skype, Insomnia.rest, Atom, Slack, GraphQL IDE and React Native Debugger all close so smoothly when you CMD+Q

@yishn
Copy link
Member

yishn commented Dec 6, 2018

@abderrahmane-tj You're welcome to figure out how VS Code does it and send in a pull request.

@yishn yishn mentioned this issue Feb 6, 2020
Closed
@yishn yishn added the blocked label Mar 1, 2020
@trotro
Copy link

trotro commented Apr 22, 2020

Any news on this bug ? It’s still happening on Sabaki v0.51.1 and macos 10.15.4.
We have to close it (cmd+Q) twice to close the app.

@yishn
Copy link
Member

yishn commented Apr 22, 2020

Please follow electron/electron#9966 for updates.

@yishn yishn mentioned this issue May 7, 2020
Closed
@Tenchi2xh Tenchi2xh mentioned this issue May 22, 2020
Closed
@yishn yishn mentioned this issue Jan 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked bug electron help wanted macos
Milestone
Backlog
Development

No branches or pull requests
5 participants
@atahrijouti @golddranks @trotro @yishn @Jendker