Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in calculation of covariance matrix #16

Closed
harshitbansal05 opened this issue May 21, 2018 · 1 comment
Closed

Error in calculation of covariance matrix #16

harshitbansal05 opened this issue May 21, 2018 · 1 comment

Comments

@harshitbansal05
Copy link

I think that there's an error in the calculation of covariance matrices. In the line xm = torch.mean(source, 1, keepdim=True) - source, imo 1 must be replaced by 0, as I would like to calculate the mean of each feature along the entire batch. Please correct me if I am wrong.
Thanks, wonderful work by the way.
@SSARCandy
Copy link
Owner

You're right, I'll fix it. Thanks
Interestingly, this bug didn't affect the performance much, the accuracy after bug fixed is about ~58%, it is ~56% before the fix. 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SSARCandy @harshitbansal05