Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The point of self.target_fc? #15

Closed
georgeadam opened this issue Apr 26, 2018 · 1 comment
Closed

The point of self.target_fc? #15

georgeadam opened this issue Apr 26, 2018 · 1 comment

Comments

@georgeadam
Copy link

Hi,

I was using the code from models.py to try and improve transfer learning results between two datasets. It made me wonder what the point of self.target_fc is in the DeepCORAL class since it is never actually used in the forward pass. Instead, `self.source_fc' is applied to both the source and target data.

Also, in main.py the test function has a mode argument which selects the output to return. Given the fact that it calls model(data, data) and that there is no difference between how these two inputs will be processed, is such indexing redundant?

@SSARCandy
Copy link
Owner

You are correct, those are legacy codes, going to clean it up, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants