Initial commit static site tf module #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested the module on platform-engg stg account. |
niroz89
reviewed
Jan 16, 2023
cloudfront.tf
Outdated
| @@ -0,0 +1,65 @@ | |||
| module "cdn" { | |||
| source = "terraform-aws-modules/cloudfront/aws" | |||
There was a problem hiding this comment.
Version added
| }, var.origin_access_identities) | ||
|
|
||
| origin = merge({ | ||
| origin_access_identity = { |
There was a problem hiding this comment.
are we able to switch to OAC instead of OAI..?
There was a problem hiding this comment.
@niroz89 the cloudfront module which i am taking reference currently OAC is not added, i saw few PR's to add support for OAC, but not merged yet. Once its added i will include OAC in our module as well.
terraform-aws-modules/terraform-aws-cloudfront#97
or shall we add as a resource for using OAC in static site module?
There was a problem hiding this comment.
Okk, we can wait until the PR gets merged.
s3.tf
Outdated
| @@ -0,0 +1,31 @@ | |||
| module "s3" { | |||
| source = "terraform-aws-modules/s3-bucket/aws" | |||
| version = "3.5.0" | |||
There was a problem hiding this comment.
Suggested change
| version = "3.5.0" | |
| version = "~> 3.5.0" |
versions.tf
Outdated
| required_providers { | ||
| aws = { | ||
| source = "hashicorp/aws" | ||
| version = ">= 4.18" |
There was a problem hiding this comment.
Suggested change
| version = ">= 4.18" | |
| version = ">= 4.50" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.