Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Error with Item Buttons #406

Closed
BaronSolace opened this issue Feb 26, 2025 · 1 comment
Closed

Bug: Error with Item Buttons #406

BaronSolace opened this issue Feb 26, 2025 · 1 comment
Assignees
Labels
Blizzard Bug This is an issue with the default UI. Unrelated This issue isn't related to this project.

Comments

@BaronSolace
Copy link

BaronSolace commented Feb 26, 2025

Game Flavor

Retail

Game Version

11.1

Add-On Version

11.0.2

Error Message

91x ...ns/Blizzard_ItemButton/Shared/ItemButtonTemplate.lua:256: attempt to call global 'GetItemButtonIconTexture' (a nil value)
[Blizzard_ItemButton/Shared/ItemButtonTemplate.lua]:256: in function 'GetItemButtonIconTexture'
[Masque/Core/Button.lua]:76: in function <Masque/Core/Button.lua:75>
[Masque/Core/Button.lua]:317: in function <Masque/Core/Button.lua:216>
[Masque/Core/Group.lua]:136: in function 'AddButton'
[Baganator/ItemViewCommon/Utilities.lua]:390: in function 'MasqueRegistration'
[Baganator/ItemViewCommon/ContainerSlots.lua]:462: in function <...eBaganator/ItemViewCommon/ContainerSlots.lua:408>
[C]: in function 'CreateFrame'
[Baganator/ViewManagement/Initialize.lua]:133: in function <...rfaceBaganator/ViewManagement/Initialize.lua:131>
[Baganator/ViewManagement/Initialize.lua]:589: in function <...rfaceBaganator/ViewManagement/Initialize.lua:588>
[C]: in function 'xpcall'
[Baganator/ViewManagement/Initialize.lua]:588: in function 'GenerateFrameGroup'
[Baganator/Skins/Main.lua]:38: in function <Baganator/Skins/Main.lua:33>

Locals:
self = Button {
 IconOverlay = Texture {
 }
 __MSQ_bType = "Item"
 showMatchHighlight = true
 masqueApplied = true
 icon = Baganator_SingleViewBackpackViewFramedarkIconTexture {
 }
 __MSQ_Scale = 1
 HighlightTexture = Texture {
 }
 __MSQ_Enabled = true
 __Regions = <table> {
 }
 PushedTexture = Texture {
 }
 Count = Baganator_SingleViewBackpackViewFramedarkCount {
 }
 searchOverlay = Baganator_SingleViewBackpackViewFramedarkSearchOverlay {
 }
 __MSQ_Icon = Baganator_SingleViewBackpackViewFramedarkIconTexture {
 }
 NormalTexture = Baganator_SingleViewBackpackViewFramedarkNormalTexture {
 }
 IconOverlay2 = Texture {
 }
 IconBorder = Texture {
 }
 __MSQ_Addon = "Baganator"
 __MSQ_Normal_Skin = <table> {
 }
 __MSQ_Normal = Baganator_SingleViewBackpackViewFramedarkNormalTexture {
 }
 __MSQ_Empty_Type = true
 __MSQ_Shape = "Blizzard"
 ItemContextOverlay = Texture {
 }
 __MSQ_Skin = <table> {
 }
 __MSQ_Normal_Hook = true
 __MSQ_oType = "Button"
 __MSQ_IsItem = true
 Stock = Baganator_SingleViewBackpackViewFramedarkStock {
 }
 SlotBackground = Texture {
 }
}
(*temporary) = nil
(*temporary) = Button {
 IconOverlay = Texture {
 }
 __MSQ_bType = "Item"
 showMatchHighlight = true
 masqueApplied = true
 icon = Baganator_SingleViewBackpackViewFramedarkIconTexture {
 }
 __MSQ_Scale = 1
 HighlightTexture = Texture {
 }
 __MSQ_Enabled = true
 __Regions = <table> {
 }
 PushedTexture = Texture {
 }
 Count = Baganator_SingleViewBackpackViewFramedarkCount {
 }
 searchOverlay = Baganator_SingleViewBackpackViewFramedarkSearchOverlay {
 }
 __MSQ_Icon = Baganator_SingleViewBackpackViewFramedarkIconTexture {
 }
 NormalTexture = Baganator_SingleViewBackpackViewFramedarkNormalTexture {
 }
 IconOverlay2 = Texture {
 }
 IconBorder = Texture {
 }
 __MSQ_Addon = "Baganator"
 __MSQ_Normal_Skin = <table> {
 }
 __MSQ_Normal = Baganator_SingleViewBackpackViewFramedarkNormalTexture {
 }
 __MSQ_Empty_Type = true
 __MSQ_Shape = "Blizzard"
 ItemContextOverlay = Texture {
 }
 __MSQ_Skin = <table> {
 }
 __MSQ_Normal_Hook = true
 __MSQ_oType = "Button"
 __MSQ_IsItem = true
 Stock = Baganator_SingleViewBackpackViewFramedarkStock {
 }
 SlotBackground = Texture {
 }
}
(*temporary) = "attempt to call global 'GetItemButtonIconTexture' (a nil value)"
@StormFX
Copy link
Member

StormFX commented Feb 26, 2025

This is a bug with Blizzard's code. Until they fix it or I get a work-around added to Masque, you can change line 76 of Masque\Core\Button.lua from:

    local Region = Button:GetItemButtonIconTexture()

To:

    --local Region = Button:GetItemButtonIconTexture()
    local Region = Button.Icon or Button.icon or _G[Button:GetName().."IconTexture"]

@StormFX StormFX changed the title Bug: TITLE weird interaction with any item addons Bug: Error with Item Buttons Feb 26, 2025
@StormFX StormFX added Bug An error or unexpected behavior. Unrelated This issue isn't related to this project. labels Feb 26, 2025
@StormFX StormFX marked this as a duplicate of #407 Feb 26, 2025
@StormFX StormFX added Blizzard Bug This is an issue with the default UI. and removed Bug An error or unexpected behavior. labels Feb 26, 2025
@StormFX StormFX moved this from Todo to In Progress in Client Updates Feb 26, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Client Updates Feb 26, 2025
@StormFX StormFX added this to the Release: 11.1.0 milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blizzard Bug This is an issue with the default UI. Unrelated This issue isn't related to this project.
Projects
Status: Done
Development

No branches or pull requests

2 participants