Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy subsystem code #1533

Closed
17 tasks done
heinezen opened this issue Sep 11, 2023 · 0 comments · Fixed by #1550
Closed
17 tasks done

Remove legacy subsystem code #1533

heinezen opened this issue Sep 11, 2023 · 0 comments · Fixed by #1550
Assignees
@heinezen
Labels
code quality Does not alter behavior, but beauty of our code lang: c++ Done in C++ code

Comments

@heinezen
Copy link
Member

heinezen commented Sep 11, 2023 •
edited
Loading

A lot of the C++ subsystems in libopenage have been rewritten using the new decoupled architecture. However, the old (now unused) code parts are still there and should be removed one by one. We should check if parts of the code are still "salvagable" for the new architecture, but most of them are probably just dead weight by now.

  • Asset management (yes, there are 3 deprecated asset managers)
    • openage::AssetManager
    • openage::LegacyAssetManager
    • openage::presenter::AssetManager
  • Deprecated Coordinate types (libopenage/coord)
    • CoordManager
    • Deprecated transformations between types
  • Gamedata dummy classes (libopenage/gamedata)
  • Old gamestate
    • Game logic (libopenage/gamestate/old)
    • Unit handling (libopenage/unit)
  • Old input system (libopenage/input/legacy)
  • Old GUI (libopenage/gui)
  • Old renderer
    • Logic (libopenage/presenter/legacy)
    • Data classes (texure, etc.)
  • Old Terrain (libopenage/terrain)
@heinezen heinezen added lang: c++ Done in C++ code code quality Does not alter behavior, but beauty of our code labels Sep 11, 2023
@heinezen heinezen self-assigned this Sep 17, 2023
@heinezen heinezen mentioned this issue Sep 23, 2023
Merged
17 tasks
@github-project-automation github-project-automation bot moved this from To do to Done in openage code quality Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heinezen heinezen

Labels
code quality Does not alter behavior, but beauty of our code lang: c++ Done in C++ code
Projects
openage code quality
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove legacy subsystem code heinezen/openage
1 participant
@heinezen