Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path is Linked which reloads the page and the flow #5

Closed
jkenzer opened this issue Apr 6, 2022 · 8 comments
Closed

Path is Linked which reloads the page and the flow #5

jkenzer opened this issue Apr 6, 2022 · 8 comments

Comments

@jkenzer
Copy link

jkenzer commented Apr 6, 2022

Is this the same code as this package?

If so, many thanks for the contribution to the community and for making it available. If not, then this may or may not be applicable to your code.

The path works great, but each stage in the path is hyperlinked. If a user clicks on the status, it reloads the page the flow is embedded in which starts my flow over again.

image

Would it be possible to not make these clickable or set to preventDefault on click?

@esnorris
Copy link

Encountering the same issue which will cause the flow's progress to be lost when the page is reloaded.

@egyptguy
Copy link
Collaborator

egyptguy commented Aug 4, 2022

Hi @jkenzer - thanks for reporting this! I've fixed this in an LWC version of the component that I'll be releasing shortly here (and on the AppExchange once the security review is complete). Thanks for making this open source project better! @esnorris thanks for confirming the problem, too!

@jverelst
Copy link

@egyptguy I was also running into this issue and happy to see that it is already fixed in the upcoming version! Thanks for actively maintaining this package! It saved me a lot of time, because I feared I had to build something myself.

Any idea yet when the new package is released? It's not necessary for me to wait for the Appexchange release, I can just install it by package id (and I am willing to also test it on our sandbox if you like)

@egyptguy
Copy link
Collaborator

A quick update: I'm conducting final testing now for an LWC version of the component and hope to get it through the security review in the next week or two.

@jverelst apologies I can't release an updated package until it passes the security review, but if you're using the unmanaged package version you can make the fix by simply removing the tags (and their end tags) from lines 219, 233, and 247 of the component's markup, as they were unnecessary elements of the SLDS blueprint.

@jkenzer
Copy link
Author

jkenzer commented Sep 14, 2022

Thank you for the update. I appreciate it and your work on this project.

@egyptguy
Copy link
Collaborator

@jkenzer @jverelst @esnorris thank you for your feedback and patience. v2.0 is now live and available as an upgrade! It resolves this issue, although I will leave the issue open for a while longer in case there are lingering issues not caught during testing. To try it out, I would recommend verifying in a sandbox prior to installing in production.

@jkenzer
Copy link
Author

jkenzer commented Sep 23, 2022

@egyptguy I just tested in Sandbox and pushed to production. Works perfect. Thanks!

@jkenzer jkenzer closed this as completed Sep 23, 2022
@jverelst
Copy link

I've also tested it in a scratch org, and I do happen to see a difference in behaviour between the old component and the new LWC component.

The difference is between the rendering of a path, when you are in the final step. So I was wondering if I want to show in my path that I am in the last step, but that stap hasn't yet completed, how do I do that with the new LWC component?

Original (version 1.2)

image

renders like:

image

(to get the last step to be fully green, you can set the percentage to '100' and use a step name that isn't in the list of steps, that was a workaround that I was using).

LWC version (2.0)

image

renders like:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants