scst-trunk fails to build on RHEL 8.6

[mikeyjoon]

I tried building scst-trunk (svn co as of 8/18/2022) on an RHEL 8.6 system and got the following error:

[2022-08-19 13:38:06] make[3]: Entering directory '/usr/src/kernels/4.18.0-372.9.1.el8.x86_64'
[2022-08-19 13:38:08] CC [M] /tmp/ontap_mediator.PC0Imv/ontap-mediator-1.5.0/ontap-mediator-1.5.0/dist/scst/scst-3.7.0-pre/scst/src/dev_handlers/scst_cdrom.o
[2022-08-19 13:38:09] CC [M] /tmp/ontap_mediator.PC0Imv/ontap-mediator-1.5.0/ontap-mediator-1.5.0/dist/scst/scst-3.7.0-pre/scst/src/dev_handlers/scst_changer.o
[2022-08-19 13:38:10] CC [M] /tmp/ontap_mediator.PC0Imv/ontap-mediator-1.5.0/ontap-mediator-1.5.0/dist/scst/scst-3.7.0-pre/scst/src/dev_handlers/scst_disk.o
[2022-08-19 13:38:11] CC [M] /tmp/ontap_mediator.PC0Imv/ontap-mediator-1.5.0/ontap-mediator-1.5.0/dist/scst/scst-3.7.0-pre/scst/src/dev_handlers/scst_modisk.o
[2022-08-19 13:38:13] CC [M] /tmp/ontap_mediator.PC0Imv/ontap-mediator-1.5.0/ontap-mediator-1.5.0/dist/scst/scst-3.7.0-pre/scst/src/dev_handlers/scst_tape.o
[2022-08-19 13:38:14] CC [M] /tmp/ontap_mediator.PC0Imv/ontap-mediator-1.5.0/ontap-mediator-1.5.0/dist/scst/scst-3.7.0-pre/scst/src/dev_handlers/scst_vdisk.o
[2022-08-19 13:38:15] /tmp/ontap_mediator.PC0Imv/ontap-mediator-1.5.0/ontap-mediator-1.5.0/dist/scst/scst-3.7.0-pre/scst/src/dev_handlers/scst_vdisk.c: In function ‘vdisk_blockio_flush’:
[2022-08-19 13:38:15] /tmp/ontap_mediator.PC0Imv/ontap-mediator-1.5.0/ontap-mediator-1.5.0/dist/scst/scst-3.7.0-pre/scst/src/dev_handlers/scst_vdisk.c:489:9: error: too many arguments to function ‘blkdev_issue_flush’
[2022-08-19 13:38:15] res = blkdev_issue_flush(bdev, gfp_mask);
[2022-08-19 13:38:15] ^~~~~~~~~~~~~~~~~~
[2022-08-19 13:38:15] In file included from ./include/linux/blk-cgroup.h:23,
[2022-08-19 13:38:15] from ./include/linux/writeback.h:15,
[2022-08-19 13:38:15] from /tmp/ontap_mediator.PC0Imv/ontap-mediator-1.5.0/ontap-mediator-1.5.0/dist/scst/scst-3.7.0-pre/scst/src/dev_handlers/scst_vdisk.c:40:
[2022-08-19 13:38:15] ./include/linux/blkdev.h:1288:5: note: declared here
[2022-08-19 13:38:15] int blkdev_issue_flush(struct block_device *bdev);
[2022-08-19 13:38:15] ^~~~~~~~~~~~~~~~~~
[2022-08-19 13:38:15] make[4]: *** [scripts/Makefile.build:322: /tmp/ontap_mediator.PC0Imv/ontap-mediator-1.5.0/ontap-mediator-1.5.0/dist/scst/scst-3.7.0-pre/scst/src/dev_handlers/scst_vdisk.o] Error 1
[2022-08-19 13:38:15] make[3]: *** [Makefile:1577: module/tmp/ontap_mediator.PC0Imv/ontap-mediator-1.5.0/ontap-mediator-1.5.0/dist/scst/scst-3.7.0-pre/scst/src/dev_handlers] Error 2
[2022-08-19 13:38:15] make[3]: Leaving directory '/usr/src/kernels/4.18.0-372.9.1.el8.x86_64'
[2022-08-19 13:38:15] make[2]: *** [Makefile:76: all] Error 2
[2022-08-19 13:38:15] make[2]: Leaving directory '/tmp/ontap_mediator.PC0Imv/ontap-mediator-1.5.0/ontap-mediator-1.5.0/dist/scst/scst-3.7.0-pre/scst/src'
[2022-08-19 13:38:15] make[1]: *** [Makefile:39: install] Error 2
[2022-08-19 13:38:15] make[1]: Leaving directory '/tmp/ontap_mediator.PC0Imv/ontap-mediator-1.5.0/ontap-mediator-1.5.0/dist/scst/scst-3.7.0-pre/scst'
[2022-08-19 13:38:15] make: *** [Makefile:158: scst_install] Error 2
[root@scs000088802-1 ~]# cat /etc/redhat-release
Red Hat Enterprise Linux release 8.6 (Ootpa)
[root@scs000088802-1 ~]# cat /etc/os-release
NAME="Red Hat Enterprise Linux"
VERSION="8.6 (Ootpa)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="8.6"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Red Hat Enterprise Linux 8.6 (Ootpa)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:8::baseos"
HOME_URL="https://www.redhat.com/"
DOCUMENTATION_URL="https://access.redhat.com/documentation/red_hat_enterprise_linux/8/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_BUGZILLA_PRODUCT_VERSION=8.6
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.6"
[root@scs000088802-1 ~]#

Please, let me know if there is fix for this?

[mikeyjoon]

OS information:

[root@scs000088802-1 ~]# uname -r
4.18.0-372.9.1.el8.x86_64
[root@scs000088802-1 ~]# uname -a
Linux scs000088802-1 4.18.0-372.9.1.el8.x86_64 #1 SMP Fri Apr 15 22:12:19 EDT 2022 x86_64 x86_64 x86_64 GNU/Linux
[root@scs000088802-1 ~]# cat /etc/os-release
NAME="Red Hat Enterprise Linux"
VERSION="8.6 (Ootpa)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="8.6"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Red Hat Enterprise Linux 8.6 (Ootpa)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:8::baseos"
HOME_URL="https://www.redhat.com/"
DOCUMENTATION_URL="https://access.redhat.com/documentation/red_hat_enterprise_linux/8/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_BUGZILLA_PRODUCT_VERSION=8.6
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.6"
[root@scs000088802-1 ~]#

Please, help!

[lnocturno]

Hi,

Support for the RHEL 8.6 was added in commit c20d0ed

This commit has also been ported to the SCST 3.6 stable branch
https://github.com/SCST-project/scst/tree/3.6.x

Could you check the version of SCST you are using?

Thanks,
Gleb

[mikeyjoon]

Hi Gleb,

The version of SCST I used to install on RHEL 8.6: 3.7.0-pre
I will try grabbing from https://github.com/SCST-project/scst/tree/3.6.x and let you know failed again. Please, keep this ticket open until I update again with my results.

Thanks again,
Mike

[mikeyjoon]

scs000088802

Hi Gleb,

It is confirmed. https://github.com/SCST-project/scst/tree/3.6.x does have the necessary changes to make RHEL 8.6 work....thanks so much.

Question: Is this change going to go into final release of 3.7.0? At the moment, it has not be taken back to scst-trunk at svn://svn.code.sf.net/p/scst/svn/trunk

Thanks so much,
Mike

[lnocturno]

Hi Mike,

Question: Is this change going to go into final release of 3.7.0? At the moment, it has not be taken back to scst-trunk at svn://svn.code.sf.net/p/scst/svn/trunk

This changes have already been there because the next 3.7.0 release will be created from the master branch of this GitHub repository.
svn-trunk is deprecated and no longer supported. Please use this Git repository instead (master branch for the upstream changes, 3.6.x as latest release stable branch)

Thanks,
Gleb