Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infra): release commands #7978

Merged
merged 4 commits into from
Dec 7, 2023
Merged

fix(infra): release commands #7978

merged 4 commits into from
Dec 7, 2023

Conversation

pskelin
Copy link
Contributor

@pskelin pskelin commented Dec 7, 2023

build commands don't run per project anymore, due to the way that typescript runs on the whole monorepo.

the prepublishOnly commands used to run build per package, but that has always relied on dependent packages being built first.

the build command is actually unnecessary, as a full ci:releasebuild is running before it. With this change, a tsc build is run as a prepublishOnly check, as it will fail in case a full build was not run before it.

@pskelin pskelin requested a review from ilhan007 December 7, 2023 15:04
@pskelin pskelin merged commit b0e653c into main Dec 7, 2023
@pskelin pskelin deleted the fix-release-commands branch December 7, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants