fix: inline sources in the .map file so the src folder is not mandatory #6732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current source map files contained a link to the source file so the
srcfolder is published to npm. This was breaking for thesrc/generatedcontent as it has source maps, but the sources are ignored and not shipped.With this change, the sources are inline in the .map file so shipping source files is no longer necessary
Now the
.mapfile contains a string value inside"sourcesContent"The
srcfolder is still shipped, but only the.hbs,.propertiesand.cssfiles as necessary as they might be used by other packages.Fixes: #6711
Fixes: #6446