New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support SAPBusinessSuite icons v1 and v2 font ( Horizon ) #6535

Merged

hinzzx merged 10 commits into main from bs-icons-v1-v2

Feb 20, 2023

Contributor

hinzzx commented Feb 17, 2023 •

edited by ilhan007

Loading

Changes

SAP Business Suite Icons

The icon collection now supports two versions ( v1 and v2 ).
The old Quartz and the newly generated Horizon collections json files are now /icons-business-suite/src/v1 and /icons-business-suite/src/v2 respectively.

API

business-suite/add-polygone -> now loads business-suite-v1/add-polygone in Quartz and business-suite-v2/add-polygone in Horizon
business-suite-v1/add-polygone -> forces SAP Business Suite icons v1 in all themes
business-suite-v2/add-polygone -> forces SAP Business Suite icons v2 in all themes

Fixes: #6316

hinzzx added 3 commits

February 17, 2023 17:24


          feat: support business icons v1 and v2 font ( Horizon )

e77a191


          feat: self code review change

6d40bed


          feat: fix typo

ilhan007 reviewed

View reviewed changes

packages/main/test/pages/Icon_and_theming.html Outdated Show resolved Hide resolved

ilhan007 reviewed

View reviewed changes

packages/main/test/pages/Icon_and_theming.html Outdated Show resolved Hide resolved


          feat: fix typo

92e9670

ilhan007 reviewed

View reviewed changes

packages/icons-business-suite/src/json-imports/Icons.ts Outdated Show resolved Hide resolved

ilhan007 reviewed

View reviewed changes

packages/base/src/config/Icons.ts Show resolved Hide resolved

ilhan007 reviewed

View reviewed changes

packages/base/src/config/Icons.ts Show resolved Hide resolved

Member

ilhan007 commented Feb 17, 2023

The issue is not referenced, you need to link it

ilhan007 added the TOPIC Core label

ilhan007 changed the title ~~feat: support business icons v1 and v2 font ( Horizon )~~ feat: support SAPBusinessSuite icons v1 and v2 font ( Horizon )

Member

ilhan007 commented Feb 18, 2023

The README of the package should also be updated to reflect the changes.


          feat: code review changes

90c9f8d

ilhan007 reviewed

View reviewed changes

packages/base/src/config/Icons.ts Outdated Show resolved Hide resolved


          feat: correct alias of business-suite

295398f

ilhan007 reviewed

View reviewed changes

packages/icons-business-suite/README.md Outdated Show resolved Hide resolved

hinzzx and others added 4 commits

February 20, 2023 09:47


          feat: fix typos and code review change

967ea89


          feat: add similarity in icon versions in readme.md

dcea740


          Merge branch 'main' into bsicons

8a5b07d


          chore: add test

efda464

ilhan007 approved these changes

View reviewed changes

hinzzx merged commit 38233b9 into main

hinzzx deleted the bs-icons-v1-v2 branch

February 20, 2023 11:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels