Skip to content

Commit 601247e

Browse files
authored
refactor(ui5-card): remove ICardHeader interface (#8497)
Removes the `ICardHeader` interface as no other header types are currently supported or requested. BREAKING CHANGE: Removed the `ICardHeader` interface. If you previously used the interface ```ts import type { ICardHeader } from "@ui5/webcomponents-base/dist/Card.js" ``` Use the CardHeader type instead: ```ts import type CardHeader from "@ui5/webcomponents-base/dist/CardHeader.js" ``` Related to [#8461](#8461)
1 parent aa463d9 commit 601247e

File tree

2 files changed

+4
-23
lines changed

2 files changed

+4
-23
lines changed

packages/main/src/Card.ts

+3-17
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,11 @@ import {
1212
ARIA_ROLEDESCRIPTION_CARD,
1313
ARIA_LABEL_CARD_CONTENT,
1414
} from "./generated/i18n/i18n-defaults.js";
15+
import type CardHeader from "./CardHeader.js";
1516

1617
// Styles
1718
import cardCss from "./generated/themes/Card.css.js";
1819

19-
/**
20-
* Interface for components that may be slotted inside `ui5-card` as header
21-
* @public
22-
*/
23-
interface ICardHeader extends HTMLElement {
24-
subtitleText: string,
25-
titleText: string,
26-
status: string,
27-
interactive: boolean,
28-
}
29-
3020
/**
3121
* @class
3222
* ### Overview
@@ -40,7 +30,7 @@ interface ICardHeader extends HTMLElement {
4030
*
4131
* ### ES6 Module Import
4232
*
43-
* `import "@ui5/webcomponents/dist/Card";`
33+
* `import "@ui5/webcomponents/dist/Card.js";`
4434
*
4535
* `import "@ui5/webcomponents/dist/CardHeader.js";` (for `ui5-card-header`)
4636
* @constructor
@@ -93,7 +83,7 @@ class Card extends UI5Element {
9383
* @public
9484
*/
9585
@slot({ type: HTMLElement, invalidateOnChildChange: true })
96-
header!: Array<ICardHeader>;
86+
header!: Array<CardHeader>;
9787

9888
static i18nBundle: I18nBundle;
9989

@@ -129,7 +119,3 @@ class Card extends UI5Element {
129119
Card.define();
130120

131121
export default Card;
132-
133-
export type {
134-
ICardHeader,
135-
};

packages/main/src/CardHeader.ts

+1-6
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { getI18nBundle } from "@ui5/webcomponents-base/dist/i18nBundle.js";
99
import { isSpace, isEnter } from "@ui5/webcomponents-base/dist/Keys.js";
1010
import { isFirefox } from "@ui5/webcomponents-base/dist/Device.js";
1111
import Integer from "@ui5/webcomponents-base/dist/types/Integer.js";
12-
import type { ICardHeader } from "./Card.js";
1312
import CardHeaderTemplate from "./generated/templates/CardHeaderTemplate.lit.js";
1413

1514
import {
@@ -36,7 +35,6 @@ import cardHeaderCss from "./generated/themes/CardHeader.css.js";
3635
*
3736
* `import "@ui5/webcomponents/dist/CardHeader";`
3837
* @constructor
39-
* @implements {ICardHeader}
4038
* @extends UI5Element
4139
* @public
4240
* @since 1.0.0-rc.15
@@ -59,7 +57,7 @@ import cardHeaderCss from "./generated/themes/CardHeader.css.js";
5957
* @public
6058
*/
6159
@event("click")
62-
class CardHeader extends UI5Element implements ICardHeader {
60+
class CardHeader extends UI5Element {
6361
/**
6462
* Defines the title text.
6563
* @default ""
@@ -238,6 +236,3 @@ class CardHeader extends UI5Element implements ICardHeader {
238236
CardHeader.define();
239237

240238
export default CardHeader;
241-
export type {
242-
ICardHeader,
243-
};

0 commit comments

Comments
 (0)