Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visitor in Fosstars rating core to handle SecGo tests #873

Closed
sourabhsparkala opened this issue Sep 7, 2022 · 0 comments
Closed

Fix visitor in Fosstars rating core to handle SecGo tests #873

sourabhsparkala opened this issue Sep 7, 2022 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@sourabhsparkala
Copy link
Member

There bug was introduced after feature implementation #730

The Scenario is that if a GitHub action uses GoSec without any arguments --include or --exclude
And if there is another step that has arguments --include or --exclude, then the current implementation returns true for stepArguments

Which is wrong.

Things to do:

  • Fix the current implementation, such that argument check is conducted only if the step uses or runs GoSec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants