Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Destinaitons with authentication type OAuth2Password #1399

Closed
gregorwolf opened this issue Jul 4, 2021 · 6 comments
Closed

Support for Destinaitons with authentication type OAuth2Password #1399

gregorwolf opened this issue Jul 4, 2021 · 6 comments
Assignees
Labels
feature request Requests for new functionality

Comments

@gregorwolf
Copy link

I'm trying to call the Cloud Foundry API using the Cloud SDK for JavaScript. For that I've created a Destinaitons with authentication type OAuth2Password in my SAP BTP Subaccount and added this commit to my bookshop-demo sample project. Unfortunately when I call the implementation I get the following error message:

Failed to build HTTP request for destination: failed to build headers!
The destination used "OAuth2Password" as authentication type which is not supported by the SDK.

Would be great if the SDK could add support for the OAuth2Password authentication type. As shown in tests/cloud-foundry.http#L3 the authenticaiton itself is actually not that complicated.

@gregorwolf gregorwolf added the feature request Requests for new functionality label Jul 4, 2021
@jjtang1985
Copy link
Contributor

jjtang1985 commented Jul 5, 2021

Hi @gregorwolf ,

thanks for raising this up. I have created a backlog item. @artemkovalyov

Do you have a timeline for this feature? Do you have a workaround e.g., switching to other auth type for now?

Best regards,
Junjie

@gregorwolf
Copy link
Author

gregorwolf commented Jul 5, 2021

Hi @jjtang1985,

I've found a workaround using cf-http-client. Unfortunately the scope of this package is quite narrow. But also a plain axios solution worked. Unfortunately the Cloud Foundry API doesn't provide an Open API Specification yet.

Best regards
Gregor

@artemkovalyov
Copy link
Member

Hi @gregorwolf,

What's the priority of this for you? Is it a PoC to try this credential flow or do you need it for a production-ready App/Service?
I want to prioritize the development of this.

@gregorwolf
Copy link
Author

Hi @artemkovalyov,

we need to access the Cloud Foundry API for a productive Multitenant SAP Partner solution.

Best regards
Gregor

@artemkovalyov
Copy link
Member

Hi @gregorwolf,

I'll raise the prio for this issue. We'll keep you updated when this Auth flow is supported.

@jjtang1985
Copy link
Contributor

Hi @gregorwolf,
the support of the new auth type OAuth2Password has been released in 1.48.0.

I'll close this ticket and please reopen if you have questions.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new functionality
Projects
None yet
Development

No branches or pull requests

4 participants